Loading docs offline takes forever

RESOLVED FIXED

Status

Add-on SDK
Documentation
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: erikvold, Assigned: canuckistani)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

When you try to load the offline documentation (via cfx docs) it takes forever to load because the first thing every page tries to do is connect to google.com for our cse stuff I assume.

All remote JS should be that last thing to be fetched.
Assignee: nobody → jgriffiths

Comment 1

5 years ago
Created attachment 709084 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/757

Pointer to Github pull-request
Comment on attachment 709084 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/757

I just moved the script tag to the bottom.
Attachment #709084 - Flags: review?(wbamberg)
Attachment #709084 - Flags: review?(wbamberg) → review+

Comment 3

5 years ago
Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/8b8a1ca7711b955b78fe8e089d289dc23e1ea6ae
bug 836955 - move Google JS loading to the bottom of the page to improve the offline case.

https://github.com/mozilla/addon-sdk/commit/2c17f70859ec89e90568e7d2f4a015247d4b411d
Merge pull request #757 from canuckistani/bug_836955

Fix for bug 836955. - move Google JS loading to the bottom of the page to improve...
Reopen if that wasn't sufficient for a fix.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.