836980 - Indicate when no jobs are chosen

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Steve Fink [:sfink] [:s:]]

Related to bug 836962, now that trychooser defaults to -p none, it would be good to clearly indicate when the syntax chosen will produce no jobs.

Comment 1

[Steve Fink [:sfink] [:s:]]

Attachment: Indicate when no jobs are chosen

Perhaps not the most graceful implementation.

Comment 2

[Ed Morley [:emorley]]

Comment on attachment 708853 [details] [diff] [review]
Indicate when no jobs are chosen

Thank you for doing this :-)

Since platform is our only required field, do you think we should perhaps make this specific to the platform field for now, in order that we can make the warning message clearer?

Either way, I think we should not prefix the warning message with the trychooser syntax, and display just the warning - to avoid people missing it.

Comment 3

[Steve Fink [:sfink] [:s:]]

Attachment: Indicate when no jobs are chosen

This version doesn't allow you to ignore it.

Comment 4

[Steve Fink [:sfink] [:s:]]

http://hg.mozilla.org/build/tools/rev/574150a26172

Comment 5

[Ed Morley [:emorley]]

In production :-)