Closed
Bug 836985
Opened 11 years ago
Closed 11 years ago
Remove ScriptSourceHolder::rt.
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: n.nethercote, Assigned: n.nethercote)
Details
Attachments
(1 file)
6.46 KB,
patch
|
Benjamin
:
review+
|
Details | Diff | Splinter Review |
ScriptSource::destroy() doesn't use its argument. As a result, ScriptSourceHolder::rt can be removed too.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #708858 -
Flags: review?(benjamin)
Comment 2•11 years ago
|
||
Comment on attachment 708858 [details] [diff] [review] Remove ScriptSourceHolder::rt. Review of attachment 708858 [details] [diff] [review]: ----------------------------------------------------------------- Definitely one of the advantages of having |js_free| instead of a runtime method.
Attachment #708858 -
Flags: review?(benjamin) → review+
Comment 3•11 years ago
|
||
Comment on attachment 708858 [details] [diff] [review] Remove ScriptSourceHolder::rt. Review of attachment 708858 [details] [diff] [review]: ----------------------------------------------------------------- ::: js/src/jsscript.h @@ +1102,3 @@ > ScriptSource *ss; > public: > + ScriptSourceHolder(ScriptSource *ss) Make this explicit.
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/f24b93663ea9 https://hg.mozilla.org/integration/mozilla-inbound/rev/091c55c7215c
Comment 5•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/f24b93663ea9 https://hg.mozilla.org/mozilla-central/rev/091c55c7215c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•