Closed Bug 836985 Opened 9 years ago Closed 9 years ago

Remove ScriptSourceHolder::rt.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: n.nethercote, Assigned: n.nethercote)

Details

Attachments

(1 file)

ScriptSource::destroy() doesn't use its argument.  As a result,
ScriptSourceHolder::rt can be removed too.
Attachment #708858 - Flags: review?(benjamin)
Comment on attachment 708858 [details] [diff] [review]
Remove ScriptSourceHolder::rt.

Review of attachment 708858 [details] [diff] [review]:
-----------------------------------------------------------------

Definitely one of the advantages of having |js_free| instead of a runtime method.
Attachment #708858 - Flags: review?(benjamin) → review+
Comment on attachment 708858 [details] [diff] [review]
Remove ScriptSourceHolder::rt.

Review of attachment 708858 [details] [diff] [review]:
-----------------------------------------------------------------

::: js/src/jsscript.h
@@ +1102,3 @@
>      ScriptSource *ss;
>    public:
> +    ScriptSourceHolder(ScriptSource *ss)

Make this explicit.
https://hg.mozilla.org/mozilla-central/rev/f24b93663ea9
https://hg.mozilla.org/mozilla-central/rev/091c55c7215c
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.