nsGeolocation::WatchPosition checks the wrong storage array

RESOLVED FIXED in mozilla21

Status

()

Core
Geolocation
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jdm, Assigned: Glenna)

Tracking

Trunk
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mentor=jdm][lang=c++][good first bug])

Attachments

(1 attachment, 1 obsolete attachment)

1.14 KB, patch
jdm
: review+
Details | Diff | Splinter Review
(Reporter)

Description

4 years ago
WatchPosition should check mWatchingCallbacks, not mPendingCallbacks.

http://hg.mozilla.org/mozilla-central/annotate/50cf5bbcb180/dom/src/geolocation/nsGeolocation.cpp#l1340
(Assignee)

Comment 1

4 years ago
I'd like to take this bug
(Assignee)

Comment 2

4 years ago
Created attachment 709502 [details] [diff] [review]
proposed patch
You can go ahead and request review when you post a patch. That implicitly sets the "next action" of the bug to the reviewer, to provide feedback and make a call about whether the patch is ready to land. (Until then, the ball is in your court, as the assignee.)

(It may not always be immediately clear who an appropriate reviewer would be.  In this case, jdm's probably a good choice, since he filed the bug suggesting the change -- and if he doesn't feel comfortable reviewing, I'm sure he'll kick the review request off to a more appropriate reviewer.)
(Assignee)

Comment 4

4 years ago
Created attachment 709524 [details] [diff] [review]
Patch (v2)

Added commit message
Attachment #709502 - Attachment is obsolete: true
Attachment #709524 - Flags: review?(josh)
(Reporter)

Comment 5

4 years ago
Comment on attachment 709524 [details] [diff] [review]
Patch (v2)

Review of attachment 709524 [details] [diff] [review]:
-----------------------------------------------------------------

Great, and thanks for the commit message. I'll fix it up and commit your patch with the following message: "Bug 836994: Check the right array when using using WatchPosition. r=jdm"
Attachment #709524 - Flags: review?(josh) → review+
(Reporter)

Comment 6

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/3971bce2c85b
OS: Linux → All
Hardware: x86_64 → All
Version: unspecified → Trunk
https://hg.mozilla.org/mozilla-central/rev/3971bce2c85b
Assignee: nobody → glennal.buford
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.