836994 - nsGeolocation::WatchPosition checks the wrong storage array

Status: RESOLVED FIXED

(Core :: DOM: Geolocation, defect)

Description

[Josh Matthews [:jdm]]

WatchPosition should check mWatchingCallbacks, not mPendingCallbacks.

http://hg.mozilla.org/mozilla-central/annotate/50cf5bbcb180/dom/src/geolocation/nsGeolocation.cpp#l1340

Comment 1

[Glenna]

I'd like to take this bug

Comment 2

[Glenna]

Attachment: proposed patch

Comment 3

[Daniel Holbert [:dholbert]]

You can go ahead and request review when you post a patch. That implicitly sets the "next action" of the bug to the reviewer, to provide feedback and make a call about whether the patch is ready to land. (Until then, the ball is in your court, as the assignee.)

(It may not always be immediately clear who an appropriate reviewer would be.  In this case, jdm's probably a good choice, since he filed the bug suggesting the change -- and if he doesn't feel comfortable reviewing, I'm sure he'll kick the review request off to a more appropriate reviewer.)

Comment 4

[Glenna]

Attachment: Patch (v2)

Added commit message

Comment 5

[Josh Matthews [:jdm]]

Comment on attachment 709524 [details] [diff] [review]
Patch (v2)

Review of attachment 709524 [details] [diff] [review]:
-----------------------------------------------------------------

Great, and thanks for the commit message. I'll fix it up and commit your patch with the following message: "Bug 836994: Check the right array when using using WatchPosition. r=jdm"

Comment 6

[Josh Matthews [:jdm]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/3971bce2c85b

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/3971bce2c85b