Closed
Bug 837034
Opened 11 years ago
Closed 11 years ago
Switch MediaStream interfaces to WebIDL
Categories
(Core :: Audio/Video, defect)
Core
Audio/Video
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: roc, Assigned: roc)
References
Details
Attachments
(2 files, 1 obsolete file)
58.73 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
45.66 KB,
patch
|
jesup
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #709897 -
Flags: review?(rjesup)
Assignee | ||
Comment 2•11 years ago
|
||
Attachment #709903 -
Flags: superreview?(peterv)
Attachment #709903 -
Flags: review?(rjesup)
Assignee | ||
Comment 3•11 years ago
|
||
https://tbpl.mozilla.org/?tree=Try&rev=8635a486f84a
Assignee | ||
Comment 4•11 years ago
|
||
Grr, fix X11 bustage: https://tbpl.mozilla.org/?tree=Try&rev=e2a4e4fb51e6
Assignee | ||
Comment 5•11 years ago
|
||
Try looks green.
Updated•11 years ago
|
Attachment #709897 -
Flags: review?(rjesup) → review+
Comment 6•11 years ago
|
||
Comment on attachment 709903 [details] [diff] [review] Part 2: Convert DOMMediaStream to use WebIDL Review of attachment 709903 [details] [diff] [review]: ----------------------------------------------------------------- r- as it appears to be entirely a dup of patch1.... ::: content/html/content/public/nsHTMLMediaElement.h @@ +18,5 @@ > #include "nsIObserver.h" > #include "AudioStream.h" > #include "VideoFrameContainer.h" > #include "mozilla/CORSMode.h" > +#include "DOMMediaStream.h" isn't this a duplicate of stuff from patch 1?
Attachment #709903 -
Flags: review?(rjesup) → review-
Assignee | ||
Comment 7•11 years ago
|
||
Attachment #709903 -
Attachment is obsolete: true
Attachment #709903 -
Flags: superreview?(peterv)
Attachment #714278 -
Flags: review?(rjesup)
Updated•11 years ago
|
Attachment #714278 -
Attachment is patch: true
Updated•11 years ago
|
Attachment #714278 -
Flags: review?(rjesup) → review+
Assignee | ||
Updated•11 years ago
|
OS: Windows 7 → All
Hardware: x86_64 → All
Version: 18 Branch → Trunk
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c34f0e0628ad https://hg.mozilla.org/integration/mozilla-inbound/rev/2512bb04bbe0
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/c34f0e0628ad https://hg.mozilla.org/mozilla-central/rev/2512bb04bbe0
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite?
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Comment 10•11 years ago
|
||
<http://hg.mozilla.org/mozilla-central/rev/2512bb04bbe0#l3.26> now has a friend in the tree! <https://hg.mozilla.org/integration/mozilla-inbound/rev/6a23d4536079#l1.12>
You need to log in
before you can comment on or make changes to this bug.
Description
•