837036 - Remove SVGLocatableElement and SVGTransformableElement IDL

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[David Zbarsky (:dzbarsky)]

These have been merged into SVGGraphicsElement in the spec since SVGClipPathElement inherits from SVGElement.  This change makes SVGLocatableElement.{h,cpp} unnecessary.

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Patch

Comment 2

[Robert Longson [:longsonr]]

Comment on attachment 708940 [details] [diff] [review]
Patch

>diff --git a/content/svg/content/src/SVGTransformableElement.cpp b/content/svg/content/src/SVGTransformableElement.cpp
>--- a/content/svg/content/src/SVGTransformableElement.cpp
>+++ b/content/svg/content/src/SVGTransformableElement.cpp
>@@ -1,32 +1,33 @@
> /* -*- Mode: C++; tab-width: 2; indent-tabs-mode: nil; c-basic-offset: 2 -*- */
> /* This Source Code Form is subject to the terms of the Mozilla Public
>  * License, v. 2.0. If a copy of the MPL was not distributed with this
>  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
> 
>+#include "mozilla/dom/SVGSVGElement.h"

Should come after the SVGTransformableElement.h include

> #include "mozilla/dom/SVGTransformableElement.h"
>+#include "mozilla/dom/SVGTransformableElement.h"

So good we need it twice?

>+#include "mozilla/dom/SVGMatrix.h"

M before T

> #include "DOMSVGAnimatedTransformList.h"
> #include "nsIDOMMutationEvent.h"
>+#include "nsSVGRect.h"

S after I

> #include "nsIFrame.h"
>+#include "nsISVGChildFrame.h"
> #include "nsSVGUtils.h"
> #include "nsContentUtils.h"
>+#include "SVGContentUtils.h"

r=longsonr with nits fixed.

Comment 3

[Robert Longson [:longsonr]]

Actually not M before T since SVGTransformableElement.h is the main include.

Comment 4

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/90aa16284fae

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/90aa16284fae