embedComponents drags in optional objects when it shouldn't

RESOLVED INCOMPLETE

Status

()

RESOLVED INCOMPLETE
18 years ago
2 years ago

People

(Reporter: jud, Assigned: ccarlen)

Tracking

Trunk
Future
x86
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Reporter)

Description

18 years ago
Currently the embedding components lib links optional (overridable) components,
with required components. This carries in dead weight for embeddors who are
overriding the said components

At a minimum we should split the lib into a required lib and an optional lib. If
we could split the directory structure too, that would help even more.

maybe we should wind up w/:

embedding/components/optional[overridable]
embedding/components/required
(Assignee)

Comment 1

18 years ago
Accepting.
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla0.9.2
(Assignee)

Comment 2

18 years ago
Created attachment 37367 [details] [diff] [review]
makefile diffs
(Assignee)

Comment 3

18 years ago
The patch splits the lib into required and optional parts. It makes 2 dlls:
embedcompsopt.* and embedcompsreq.* The Mac projects are done as well. In
summary, nsPromptService and nsJSConsole were moved off into the "optional" dll.
This meant pulling nsPromptService files out of the windowwatcher dir and into
their own. Actually, now that it's done, I'm starting to think that "required"
and "optional" are not quite right. The UI components which are now in the
optional dll are there so that embeddors overriding with their own can ditch the
implementations in the optional part. It's not exactly "optional", it's
"default" Seamonkey would be pretty dead in the water without the prompt impl in
the "optional" dll. I think maybe a better name would be "default" 
(Reporter)

Comment 4

18 years ago
good point. "default" makes more sense.
(Assignee)

Comment 5

18 years ago
Created attachment 37745 [details] [diff] [review]
patch to mac build script
Per conversation with conrad, these can be moved out to later milestones.
Target Milestone: mozilla0.9.2 → mozilla1.0

Comment 7

17 years ago
Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)
Target Milestone: mozilla1.0 → mozilla1.0.1

Comment 8

17 years ago
see also bug 114658, which is about cleaning up all the different
clumped-together dlls.
Blocks: 114658
(Assignee)

Comment 9

16 years ago
Setting to milestone that's not passed.
Target Milestone: mozilla1.0.1 → mozilla1.4alpha
(Assignee)

Comment 10

16 years ago
-> Future, since the amount of unused code here is small. Comment if you disagree. 
Target Milestone: mozilla1.4alpha → Future
QA Contact: dunn5557 → apis

Comment 11

2 years ago
Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → INCOMPLETE
You need to log in before you can comment on or make changes to this bug.