83704 - embedComponents drags in optional objects when it shouldn't

Status: RESOLVED INCOMPLETE

(Core Graveyard :: Embedding: APIs, defect)

Description

[Judson Valeski]

Currently the embedding components lib links optional (overridable) components,
with required components. This carries in dead weight for embeddors who are
overriding the said components

At a minimum we should split the lib into a required lib and an optional lib. If
we could split the directory structure too, that would help even more.

maybe we should wind up w/:

embedding/components/optional[overridable]
embedding/components/required

Comment 1

[Conrad Carlen (not reading bugmail)]

Accepting.

Comment 2

[Conrad Carlen (not reading bugmail)]

Attachment: makefile diffs

Comment 3

[Conrad Carlen (not reading bugmail)]

The patch splits the lib into required and optional parts. It makes 2 dlls:
embedcompsopt.* and embedcompsreq.* The Mac projects are done as well. In
summary, nsPromptService and nsJSConsole were moved off into the "optional" dll.
This meant pulling nsPromptService files out of the windowwatcher dir and into
their own. Actually, now that it's done, I'm starting to think that "required"
and "optional" are not quite right. The UI components which are now in the
optional dll are there so that embeddors overriding with their own can ditch the
implementations in the optional part. It's not exactly "optional", it's
"default" Seamonkey would be pretty dead in the water without the prompt impl in
the "optional" dll. I think maybe a better name would be "default" 

Comment 4

[Judson Valeski]

good point. "default" makes more sense.

Comment 5

[Conrad Carlen (not reading bugmail)]

Attachment: patch to mac build script

Comment 6

[Radha on family leave (not reading bugmail)]

Per conversation with conrad, these can be moved out to later milestones.

Comment 7

[Asa Dotzler [:asa]]

Bugs targeted at mozilla1.0 without the mozilla1.0 keyword moved to mozilla1.0.1 
(you can query for this string to delete spam or retrieve the list of bugs I've 
moved)

Comment 8

[Alec Flett]

see also bug 114658, which is about cleaning up all the different
clumped-together dlls.

Comment 9

[Conrad Carlen (not reading bugmail)]

Setting to milestone that's not passed.

Comment 10

[Conrad Carlen (not reading bugmail)]

-> Future, since the amount of unused code here is small. Comment if you disagree. 

Comment 11

[Benjamin Smedberg]

Marking a bunch of bugs in the "Embedding: APIs" component INCOMPLETE in preparation to archive that component. If I have done this incorrectly, please reopen the bugs and move them to a more correct component as we don't have "embedding" APIs any more.