837044 - Convert SVGFilterElement to WebIDL

Status: RESOLVED FIXED

(Core :: SVG, defect)

Comment 1

[David Zbarsky (:dzbarsky)]

Attachment: Move SVGFilterElement to mozilla::dom

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 710516 [details] [diff] [review]
Move SVGFilterElement to mozilla::dom

r=me

Comment 3

[David Zbarsky (:dzbarsky)]

Attachment: Convert SVGFilterElement to WebIDL and remove nsIDOMSVGFilterElement, nsIDOMSVGUnitTypes

Comment 4

[David Zbarsky (:dzbarsky)]

Attachment: Convert SVGFilterElement to WebIDL and remove nsIDOMSVGFilterElement, nsIDOMSVGUnitTypes

Comment 5

[David Zbarsky (:dzbarsky)]

Attachment: Fix tests

because SVGUnitTypes is [NoInterfaceObject]

Comment 6

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 712813 [details] [diff] [review]
Convert SVGFilterElement to WebIDL and remove nsIDOMSVGFilterElement, nsIDOMSVGUnitTypes

r=me

Comment 7

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 712813 [details] [diff] [review]
Convert SVGFilterElement to WebIDL and remove nsIDOMSVGFilterElement, nsIDOMSVGUnitTypes

Er, one thing I forgot:

>+   // Returns a new nsISMILAttr object that the caller must delete
>   nsISMILAttr* ToSMILAttr(nsSVGElement* aSVGElement);

Fix the indent, please.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 713255 [details] [diff] [review]
Fix tests

Why is SVGUnitTypes [NoInterfaceObject], exactly?  That seems totally broken, if it has constants on it!

Comment 9

[Cameron McCormack (:heycam)]

Hmm.  In SVG 1.1 SVGUnitTypes was inherited by a few other concrete interfaces, so when converting to Web IDL I made it [NoInterfaceObject].  The interface does seem to be visible on window in at least Firefox and Chrome, though, so perhaps it shouldn't be [NoInterfaceObject].

Comment 10

[David Zbarsky (:dzbarsky)]

Pushed part 1: https://hg.mozilla.org/integration/mozilla-inbound/rev/5faf053cccaf

Comment 11

[David Zbarsky (:dzbarsky)]

Part 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/547bfb2239d1

I added nsIDOMSVGUnitTypes back to preserve current behavior and filed bug 842201 on removing it.  I'm not sure how the codegen is supposed to work here.  Even without the [NoInterfaceObject], SVGUnitTypesBinding is still empty.  I'll look into it when I get a chance.

Comment 12

[Boris Zbarsky [:bzbarsky]]

> Even without the [NoInterfaceObject], SVGUnitTypesBinding is still empty. 

Er...  That's really strange.  We should be generating the constants and whatnot, but maybe we somehow fail?

Please file a bug with patch that shows that problem and I'll look into what the codegen is seeing?

Comment 13

[David Zbarsky (:dzbarsky)]

Part 3 to remove the old idl: https://hg.mozilla.org/integration/mozilla-inbound/rev/fa40088b0833

Comment 14

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/5faf053cccaf
https://hg.mozilla.org/mozilla-central/rev/547bfb2239d1
https://hg.mozilla.org/mozilla-central/rev/fa40088b0833