Closed Bug 837044 Opened 7 years ago Closed 7 years ago

Convert SVGFilterElement to WebIDL

Categories

(Core :: SVG, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla21

People

(Reporter: dzbarsky, Assigned: dzbarsky)

References

Details

Attachments

(2 files, 2 obsolete files)

No description provided.
Attachment #710516 - Flags: review?(bzbarsky)
Comment on attachment 710516 [details] [diff] [review]
Move SVGFilterElement to mozilla::dom

r=me
Attachment #710516 - Flags: review?(bzbarsky) → review+
Attachment #712812 - Attachment is obsolete: true
Attachment #712812 - Flags: review?(bzbarsky)
Attachment #712813 - Flags: review?(bzbarsky)
Attached patch Fix tests (obsolete) — Splinter Review
because SVGUnitTypes is [NoInterfaceObject]
Attachment #713255 - Flags: review?(bzbarsky)
Attachment #713255 - Attachment is patch: true
Comment on attachment 712813 [details] [diff] [review]
Convert SVGFilterElement to WebIDL and remove nsIDOMSVGFilterElement, nsIDOMSVGUnitTypes

r=me
Attachment #712813 - Flags: review?(bzbarsky) → review+
Comment on attachment 712813 [details] [diff] [review]
Convert SVGFilterElement to WebIDL and remove nsIDOMSVGFilterElement, nsIDOMSVGUnitTypes

Er, one thing I forgot:

>+   // Returns a new nsISMILAttr object that the caller must delete
>   nsISMILAttr* ToSMILAttr(nsSVGElement* aSVGElement);

Fix the indent, please.
Comment on attachment 713255 [details] [diff] [review]
Fix tests

Why is SVGUnitTypes [NoInterfaceObject], exactly?  That seems totally broken, if it has constants on it!
Hmm.  In SVG 1.1 SVGUnitTypes was inherited by a few other concrete interfaces, so when converting to Web IDL I made it [NoInterfaceObject].  The interface does seem to be visible on window in at least Firefox and Chrome, though, so perhaps it shouldn't be [NoInterfaceObject].
Part 2: https://hg.mozilla.org/integration/mozilla-inbound/rev/547bfb2239d1

I added nsIDOMSVGUnitTypes back to preserve current behavior and filed bug 842201 on removing it.  I'm not sure how the codegen is supposed to work here.  Even without the [NoInterfaceObject], SVGUnitTypesBinding is still empty.  I'll look into it when I get a chance.
Whiteboard: [leave open]
Attachment #713255 - Attachment is obsolete: true
Attachment #713255 - Flags: review?(bzbarsky)
> Even without the [NoInterfaceObject], SVGUnitTypesBinding is still empty. 

Er...  That's really strange.  We should be generating the constants and whatnot, but maybe we somehow fail?

Please file a bug with patch that shows that problem and I'll look into what the codegen is seeing?
https://hg.mozilla.org/mozilla-central/rev/5faf053cccaf
https://hg.mozilla.org/mozilla-central/rev/547bfb2239d1
https://hg.mozilla.org/mozilla-central/rev/fa40088b0833
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Depends on: 842463
You need to log in before you can comment on or make changes to this bug.