837112 - Automatic crash id linking busted

Status: RESOLVED FIXED

(support.mozilla.org :: Forum, task, P3)

Description

[Noah (NoahSUMO/SolidSnake) [:Noah]]

Sometime in fall 2012, Tobbi's auto crash id linking was broken. This must have been by accident as this was a very useful feature.

It's infuriating to have to copy and paste crash ids into crash-stats.mozilla.com each time you encounter one. It's one of the main reasons I stopped assisting in crash support threads.

Feature was added by Bug 536513 on 8/13/12 but the questions forum was redesigned a short time later in Bug 781254 on 9/7/12. So I believe the changes were lost on that day. Can we get this back?

Comment 1

[Noah (NoahSUMO/SolidSnake) [:Noah]]

Example thread with crash ids: 
https://support.mozilla.org/en-US/questions/947040

Example crash id:
bp-054b8e06-f64a-439e-a66d-34ab52130114

Search results using term "crashes" & created after 1/1/2013:
https://support.mozilla.org/en-US/search?q=crashes&created=2&created_date=01%2F01%2F2013&a=1&w=2

We should not link crash ids without the "bp-" in front because those crashes have not been submitted from the user's computer. The .dmp file is still sitting in the Crash Reports/Pending folder on the user's pc so we can not submit it on their behalf b/c we'll land on a dead link/error page.

Also there are times when addon UUIDs & Windows registry UUIDs are posted on the forums and become linkified. If the regex we use could be tweaked so we don't convert UUIDs contained in { } curly braces/brackets, that would be great. Maybe I need to file a separate bug for that.

Addon UUID example:
Norton Toolbar
2013.2.1.36
false
{2D3F3651-74B9-4795-BDEC-6DA2F431CB62}

Registry UUID examples:
https://support.mozilla.org/en-US/questions/935168
----
Note to self: Bug 784614 (w/ mockups) was fixed by Bug 781254

Comment 2

[Tobias (:Tobbi) Markus]

CCing myself, since I'm the developer. :)

Comment 3

[Will Kahn-Greene [:willkg] ET needinfo? me]

I vaguely remember looking at Tobbi's code when he added it. But I don't remember any of the details.

Sounds like there are several parts to this bug:

1. figure out why crash ids are no longer getting linked
2. adjust the crash id linking to ignore crash ids that don't have bp- in them
3. adjust the crash id linking to ignore ids in { }
4. write tests for these changes

Comment 4

[Tobias (:Tobbi) Markus]

(In reply to Will Kahn-Greene [:willkg] from comment #3)
> I vaguely remember looking at Tobbi's code when he added it. But I don't
> remember any of the details.
> 
> Sounds like there are several parts to this bug:
> 
> 1. figure out why crash ids are no longer getting linked

This is happening due to locator changes. 
var postContents = $("#answers .content, #question .content, #more-system-details"); <-- those are invalid with the redesign.

> 2. adjust the crash id linking to ignore crash ids that don't have bp- in
> them

With the existing regex, this should be as easy as just removing a '?' before the "bp-".

> 3. adjust the crash id linking to ignore ids in { }

Matter of changing the regex.

> 4. write tests for these changes

I will assign this to me for the time being.

Comment 5

[Tobias (:Tobbi) Markus]

In a pull request:
https://github.com/mozilla/kitsune/pull/1113

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/424060ac5b3f25de838f6d1370c10cd1bf20834f

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod now.