837253 - "ObjectImpl.h(920) : warning C4099: 'JSObject' : type name first seen using 'class' now seen using 'struct'" (and same warning for Shape.h(444))

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Daniel Holbert [:dholbert]]

Our windows builds spam tons of warnings like:
{
e:\builds\moz2_slave\m-cen-w32-dbg\build\js\src\vm/ObjectImpl.h(920) : warning C4099: 'JSObject' : type name first seen using 'class' now seen using 'struct'

        e:\builds\moz2_slave\m-cen-w32-dbg\build\js\src\jspubtd.h(192) : see declaration of 'JSObject'
}
...and...
{
e:\builds\moz2_slave\m-cen-w32-dbg\build\js\src\vm/Shape.h(444) : warning C4099: 'JSObject' : type name first seen using 'class' now seen using 'struct'

        e:\builds\moz2_slave\m-cen-w32-dbg\build\js\src\jsobj.h(281) : see declaration of 'JSObject'
}

...for every .cpp file that #includes these headers. (ObjectImpl.h and Shape.h)

Sample log file:
https://tbpl.mozilla.org/php/getParsedLog.php?id=19360674&tree=Firefox

In both cases, it's because we have "friend struct ::JSObject", where everywhere else we refer to JSObject as a class (not a struct).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

Comment 2

[Daniel Holbert [:dholbert]]

For reference, the (correct) declarations of JSObject as a class (not a struct) that the warning message refers to are here:

> 192 class                                       JSObject;
https://mxr.mozilla.org/mozilla-central/source/js/src/jspubtd.h#192

and here:

> 281 class JSObject : public js::ObjectImpl
https://mxr.mozilla.org/mozilla-central/source/js/src/jsobj.h#281

So, this patch makes these 'friend' declarations agree with those on class-vs-struct.

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e1d18b12979

Comment 4

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/4e1d18b12979