Support selecting tests to run in in-tree mach and Makefile test commands

RESOLVED FIXED

Status

Add-on SDK
General
P3
normal
RESOLVED FIXED
4 years ago
2 years ago

People

(Reporter: mossop, Unassigned)

Tracking

(Blocks: 1 bug)

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [mach])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Bug 793928 added a way to run the jetpack tests from mach and make but it just runs all the tests. It would be good to add a way to select an individual test

Updated

4 years ago
Priority: -- → P3

Updated

4 years ago
Whiteboard: [mach]
Created attachment 734317 [details] [diff] [review]
Add ability to filter tests to mach jetpack-test

So, this seems to let me filter tests when using | mach jetpack-test |. (Or at least, | mach jetpack-test -f context | only runs the contextMenu tests, and | mach jetpack-test -f context:testUnload | only runs the contextMenu tests that include "testUnload" in the test name.)

It isn't working for me with make, though.
Attachment #734317 - Flags: feedback?(dtownsend+bugmail)
(Reporter)

Comment 2

4 years ago
Comment on attachment 734317 [details] [diff] [review]
Add ability to filter tests to mach jetpack-test

Review of attachment 734317 [details] [diff] [review]:
-----------------------------------------------------------------

I don't especially like the regexp filter method of selecting tests and would really like us to just pass the path to a test file to run, but I think that needs cfx changes and pain so I guess this is good for the interim.

gps should review this really but it looks fine for me. Mach just calls make so not sure why make isn't working. How are you running it, with something like |EXTRA_TEST_ARGS="-f context" make jetpack-tests| ?
Attachment #734317 - Flags: feedback?(dtownsend+bugmail) → feedback+

Updated

4 years ago
Duplicate of this bug: 869354

Updated

4 years ago
Duplicate of this bug: 909992
Blocks: 1117922
(Reporter)

Comment 5

2 years ago
Fixed by bug 1035512
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Depends on: 1035512
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.