Closed
Bug 837301
Opened 13 years ago
Closed 13 years ago
[pulsetranslator] Change timestamps to make use of UTC time
Categories
(Webtools :: Pulse, defect)
Webtools
Pulse
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: whimboo, Assigned: jgriffin)
Details
Attachments
(1 file)
|
680 bytes,
patch
|
whimboo
:
review+
|
Details | Diff | Splinter Review |
Right now it's kinda hard to work with Pulse messages because the original ones provide times in the Pacific time zone. Via pulsetranslator we get an additional timestamp in the local timezone. That means if the translator gets run in another timezone as Pacific we don't know how to translate those time zones.
Therefor we might want to use the UTC time zone whereever we can.
As Jonathan mentioned on bug 835749 comment 2 we do not know yet which consumers might be affected by that change. So we should handle that carefully and get an idea first what we could break.
Who knows about all the consumers we make use of internally?
| Assignee | ||
Comment 1•13 years ago
|
||
The two consumers we need to check, that I know of, are the orange factor logparser (http://hg.mozilla.org/automation/logparser/), and autophone (https://github.com/mozilla/autophone)
| Assignee | ||
Comment 2•13 years ago
|
||
Specifically, we need to determine if any consumers rely on the 'timestamp' field being in PST.
* The OF logparser does not use this field.
* Autolog does not use this field.
We should be good to change this field to UTC.
| Assignee | ||
Comment 3•13 years ago
|
||
I've verified there aren't any consumers that depend on local time in this field.
Attachment #719079 -
Flags: review?(hskupin)
| Reporter | ||
Comment 4•13 years ago
|
||
Comment on attachment 719079 [details] [diff] [review]
Make timestamp UTC
Review of attachment 719079 [details] [diff] [review]:
-----------------------------------------------------------------
Yay, for an universal time! Looks great and it will help us a lot. Thanks!
Attachment #719079 -
Flags: review?(hskupin) → review+
| Assignee | ||
Comment 5•13 years ago
|
||
| Assignee | ||
Comment 6•13 years ago
|
||
deployed
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•