Warn if -p none detected.

RESOLVED FIXED

Status

Developer Services
Mercurial: hg.mozilla.org
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: sfink, Assigned: sfink)

Tracking

Details

(Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/856] )

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
This may not be necessary after bug 836980, but there are many ways to generate try pushes, so it might be worth having this as a backstop.
(Assignee)

Comment 1

5 years ago
Created attachment 709258 [details] [diff] [review]
Detect -p none

And it has nothing to do with me wanting to land something with a try try again pun.

We could also make these pushes fail. Personally, I do quite a few pushes with things like |-p quantum_interference_patterns_of_supercooled_fluorine| (usually because I need pushes for testing releng changes), which has the same effect as -p none.
Attachment #709258 - Flags: review?(emorley)

Comment 2

5 years ago
Comment on attachment 709258 [details] [diff] [review]
Detect -p none

Sorry for the delay, dealing with the backlog after not one but two SSD failures (yey \o/).

Looks good - only change I would make is for this to fail the push (since as you say for testing, you can just enter junk instead of 'none'), otherwise my bet is on someone filing another bug in a few months time with "I pushed to try and ignored the response, and thought it would be successful since return code 0".
Attachment #709258 - Flags: review?(emorley) → review+
(Assignee)

Updated

5 years ago
Attachment #709258 - Flags: checked-in+
(Assignee)

Comment 3

5 years ago
Pushed with the suggested change (making it fail instead of just warn)

http://hg.mozilla.org/hgcustom/hghooks/rev/3b0c66182bb0
Don't forget to file the dependent IT bug to have that actually deployed.
Status: NEW → ASSIGNED
Component: Release Engineering → Release Engineering: Developer Tools
Keywords: trychooser
QA Contact: hwine

Comment 5

5 years ago
(This is an hg hook customisation; the trychooser counterpart landed in bug 836980. Will still need deploying in production.)
Component: Release Engineering: Developer Tools → Hg: Customizations
Flags: checked-in+
Keywords: trychooser
QA Contact: hwine
Product: mozilla.org → Release Engineering
Product: Release Engineering → Developer Services

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/138]

Updated

3 years ago
Whiteboard: [kanban:engops:https://kanbanize.com/ctrl_board/6/138] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/856] [kanban:engops:https://kanbanize.com/ctrl_board/6/138]
Whiteboard: [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/856] [kanban:engops:https://kanbanize.com/ctrl_board/6/138] → [kanban:engops:https://mozilla.kanbanize.com/ctrl_board/6/856]

Comment 6

2 years ago
This appears to have been fixed years ago but nobody closed the bug.
Status: ASSIGNED → RESOLVED
Last Resolved: 2 years ago
QA Contact: hwine
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.