83734 - Playback of offline IMAP copy operations fails silently

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Backend, defect, P1)

Description

[David :Bienvenu]

1. go offline
2. copy an imap message from one folder to another
3. Go online

the copy operation does not take place (fails silently because apparently the
imap server doesn't complain about a failed copy)

I'll attach a patch shortly. It's a one line change. Move works fine; it's just
copy that fails. The change is only in the code that plays back offline imap
copy operations so it won't break anything.

Comment 1

[David :Bienvenu]

nominating

Comment 2

[David :Bienvenu]

Attachment: proposed fix

Comment 3

[David :Bienvenu]

CC'ing Seth and Navin for code reviews. The bug was that we were using the
destination folder as the folder to call ReplayOfflineMoveCopy on, and we want
to use the source folder, like the routine above it does, 
nsImapOfflineSync::ProcessMoveOperation().

Comment 4

[Navin Gupta]

r=naving

Comment 5

[scottputterman]

Putting on 0.9.1 radar. If someone thinks they copied something, they might
delete the message.

Comment 6

[(not reading, please use [e-mail] instead)]

sr=sspitzer

Comment 7

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to 0.9.1 and the trunk.
(on behalf of drivers)

Comment 8

[David :Bienvenu]

fix checked in.

Comment 9

[grylchan]

Verified on commerical branch builds
2001-06-05-11-0.9.1/ -windows
2001-06-05-04-0.9.1/ -linux
2001-06-05-03-0.9.1/ -mac

Copying messages (both downloaded/non-downloaded) works in both ways:
 -right click on the message and selecting the 'copy to' option
 -Message|Copy Message option

But a bug I did see is that when copying a dowloaded message to another
folder: in the new folder, it looses it's italic(downloaded) mode.
will open a new bug on that.

adding keyword vtrunk

marking as verified

Comment 10

[grylchan]

Verified using commercial trunk builds
2001061504 -win nt 4.0
2001061508 -linux 2.2, red hat 7.0
2001061508 -mac os 9.0.4

Removing keyword vtrunk