Closed Bug 837352 Opened 8 years ago Closed 8 years ago

Don't generate dictionaries in WebIDL unless used in generated code.

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla22

People

(Reporter: wchen, Assigned: wchen)

Details

Attachments

(1 file)

We currently generate unnecessary dictionary code for interfaces with skipGen=True, except for two special dummy interfaces used for rooting. This causes problems for cases where we can't actually generate dictionary code such as worker dictionaries with a callback member.
This patch uses the dummy interfaces to root dictionaries and callbacks. Alternatively we could just specify a list of interfaces and callbacks to root right in the code.
Attachment #709330 - Flags: review?(bzbarsky)
Comment on attachment 709330 [details] [diff] [review]
Don't generate dictionary code in WebIDL unless used in generated code.

r=me
Attachment #709330 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/75ffb31383a7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.