Closed
Bug 837352
Opened 11 years ago
Closed 11 years ago
Don't generate dictionaries in WebIDL unless used in generated code.
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla22
People
(Reporter: wchen, Assigned: wchen)
Details
Attachments
(1 file)
|
1.91 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
We currently generate unnecessary dictionary code for interfaces with skipGen=True, except for two special dummy interfaces used for rooting. This causes problems for cases where we can't actually generate dictionary code such as worker dictionaries with a callback member.
|
Assignee | |
Comment 1•11 years ago
|
||
This patch uses the dummy interfaces to root dictionaries and callbacks. Alternatively we could just specify a list of interfaces and callbacks to root right in the code.
Attachment #709330 -
Flags: review?(bzbarsky)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 709330 [details] [diff] [review] Don't generate dictionary code in WebIDL unless used in generated code. r=me
Attachment #709330 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/75ffb31383a7
Flags: in-testsuite-
|
||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/75ffb31383a7
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•