837372 - nsXULElement.h not found compiling CanvasRenderingContext2D.cpp

Status: RESOLVED DUPLICATE of bug 837235

(Core :: Graphics: Canvas2D, defect)

Description

[Christian Eyrich]

Attachment: Patch that fixes the build problem

include nsXULElement.h isn't found when compiling CanvasRenderingContext2D.cpp since checkin of 134c19beec11 via bug 824589.
I'm compiling Seamonkey on Windows 8 using MSVC 11 Express with --disable-webgl.

Attached patch fixes the build problem but I'm unsure if it's the solution you guys would use.

Comment 1

[Peter Van der Beken [:peterv]]

Comment on attachment 709360 [details] [diff] [review]
Patch that fixes the build problem

Could you add it to the INCLUDES list below?

Comment 2

[Rolf Bode-Meyer]

Attachment: 2nd try

Include now moved to the main INCLUDES section.

Comment 3

[Christian Eyrich]

Ok, someone was faster. But that's fine for me.
How does checkin it in work again since I can't?

Comment 4

[Andrew McCreight [:mccr8]]

Though really this should be landed in proper patch format (author, description with bug number, etc), which I think this page describes, so it is easier for somebody to check in

https://developer.mozilla.org/en-US/docs/Creating_a_patch

Comment 5

[Andrew McCreight [:mccr8]]

Err uploaded in proper format, not landed.

Comment 6

[Markus Adrario [:Taraman]]

When I just wanted to update the patch, I discovered this was fixed in bug 837235.

Therefore marking as duplicate.