Closed
Bug 837372
Opened 11 years ago
Closed 11 years ago
nsXULElement.h not found compiling CanvasRenderingContext2D.cpp
Categories
(Core :: Graphics: Canvas2D, defect)
Tracking
()
RESOLVED
DUPLICATE
of bug 837235
People
(Reporter: ch.ey, Assigned: ch.ey)
Details
Attachments
(2 files)
869 bytes,
patch
|
Details | Diff | Splinter Review | |
938 bytes,
patch
|
peterv
:
review+
|
Details | Diff | Splinter Review |
include nsXULElement.h isn't found when compiling CanvasRenderingContext2D.cpp since checkin of 134c19beec11 via bug 824589. I'm compiling Seamonkey on Windows 8 using MSVC 11 Express with --disable-webgl. Attached patch fixes the build problem but I'm unsure if it's the solution you guys would use.
Attachment #709360 -
Flags: review?(peterv)
Comment 1•11 years ago
|
||
Comment on attachment 709360 [details] [diff] [review] Patch that fixes the build problem Could you add it to the INCLUDES list below?
Comment 2•11 years ago
|
||
Include now moved to the main INCLUDES section.
Attachment #709368 -
Flags: review?(peterv)
Updated•11 years ago
|
Attachment #709368 -
Flags: review?(peterv) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Ok, someone was faster. But that's fine for me. How does checkin it in work again since I can't?
Updated•11 years ago
|
Keywords: checkin-needed
Comment 4•11 years ago
|
||
Though really this should be landed in proper patch format (author, description with bug number, etc), which I think this page describes, so it is easier for somebody to check in https://developer.mozilla.org/en-US/docs/Creating_a_patch
Keywords: checkin-needed
Comment 5•11 years ago
|
||
Err uploaded in proper format, not landed.
Comment 6•11 years ago
|
||
When I just wanted to update the patch, I discovered this was fixed in bug 837235. Therefore marking as duplicate.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → DUPLICATE
Updated•11 years ago
|
Attachment #709360 -
Flags: review?(peterv)
You need to log in
before you can comment on or make changes to this bug.
Description
•