83739 - nsOutlinerRows::Subtree::Clear() doesn't reset mSubtreeSize

Status: VERIFIED FIXED

(Core :: XUL, defect)

Description

[Joe Hewitt (gone)]

I ran into this problem while attempting to modify a <template/> inside of an
rdf-based outliner, and then call rebuild().  I noticed that the row count of
the outliner builder doubles each time you call rebuild, causing a ton of "index
of of range assertions", because the row count is derived from the subtree size
of the root subtree.  

The subtree size simply doesn't get reset to 0 inside of
nsOutlinerRows::Subtree::Clear(). 

Teensy patch ahead.

Comment 1

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 2

[Joe Hewitt (gone)]

I cc'd blake because I suspect this may be related to the crash he filed in bug
82913

waterson, can you review this?

Comment 3

[Chris Waterson]

Thanks for fixing this. r=waterson

Comment 4

[Chris Waterson]

*** Bug 82913 has been marked as a duplicate of this bug. ***

Comment 5

[Blake Ross]

sr=blake

Comment 6

[Asa Dotzler [:asa]]

a= [e-mail] for checkin to the trunk.
(on behalf of drivers)

Comment 7

[hangas]

PDT has approved this bug for 0.9.2

Comment 8

[Joe Hewitt (gone)]

fixed

Comment 9

[Joe Hewitt (gone)]

really fixed

Comment 10

[Chad Austin]

verified checked in