83741 - can't dynamically add columns to an outliner

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Joe Hewitt (gone)]

I'm trying to repair a rotting feature in Document Inspector which allowed you
to dynamically add columns to the DOM tree.  Since I'm re-writing this tree to
use an rdf-based outliner, I'll need outliner to have this capability.

Currently, nsOutlinerBodyFrame::EnsureColumns builds of the structure of column
information, but it only does this upon construction.  If new outlinercol
elements are added via JS, this structure is never updated and the new columns
go unrecognized.

I'll smack together a fix for this in a segundo.

Comment 1

[Joe Hewitt (gone)]

Attachment: patch to fix

Comment 2

[Joe Hewitt (gone)]

There are several ways to fix this problem - the patch above is the simplest one
I could come up with, not necessarily the best.  It would be nice to rebuild the
column cache with a document observer each time an outlinercol is added/removed
- but that requires a lot more code.

Comment 3

[Joe Hewitt (gone)]

Attachment: patch post hyatt review

Comment 4

[David Hyatt]

i gave hewitt some changes on irc.  with those changes, sr=hyatt.  i suggest 
posting a third patch so that the reviewer can see it post-all my comments.

Comment 5

[Joe Hewitt (gone)]

Attachment: final patch-a-mundo

Comment 6

[John Morrison]

May God have mercy on us all. The 212 bug spam-o-rama is Now!

Comment 7

[Joe Hewitt (gone)]

fixed