Closed Bug 83743 Opened 23 years ago Closed 23 years ago

nsRange::SurroundContents() : not all control paths return value

Categories

(Core :: DOM: Selection, defect)

Product:
Core
Component:
DOM: Selection
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.2

People

(Reporter: hjtoi-bugzilla, Assigned: anthonyd)

References

Details

(Whiteboard: FIX IN HAND; waiting for checkin)

Attachments

(1 file)

new patch
7.01 KB, patch
Details | Diff | Splinter Review 
Forgot a return statement?
setting to 0.9.3.  SurroundContents probably needs to be re-written.

anthonyd
Target Milestone: --- → mozilla0.9.3
Im attaching a patch to recitify this, the patch file I am attaching has more in 
it than just the fix for this.

anthonyd
Status: NEW → ASSIGNED
Whiteboard: FIX IN HAND
Attached patch new patch — — Splinter Review 

    
    

    
  
moving to 0.9.2 to get this in.
Target Milestone: mozilla0.9.3 → mozilla0.9.2

    
  
Whiteboard: FIX IN HAND → FIX IN HAND need r=, sr=

    
    

    
  
r= from mjudge, and sr= from kin.

sending away for a=

anthonyd

    
  
Blocks: 83989

    
    

    
  
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)

    
  
Whiteboard: FIX IN HAND need r=, sr= → FIX IN HAND; waiting for checkin

    
    

    
  
fix checked in
anthonyd

    
    

    
  
damnit, really its in!
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Resolution: --- → FIXED

    
    

    
  
Verified fix checked into lxr.mozilla.org
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: