Closed
Bug 837494
Opened 11 years ago
Closed 11 years ago
re-implement `contentStyle*` using the new nsIDOMWindowUtils methods
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: zer0, Assigned: zer0)
References
Details
Attachments
(2 files)
Thanks to the works made by Gabor on platform side, now we can apply a stylesheet on a given document (bug 737003) as author sheet (bug 676054 and bug 804120). So we can implement `contentStyle*` in a better way, without using data: url and global stylesheet; see: https://github.com/mozilla/addon-sdk/wiki/contentStyle-issues for further details. This implementation will also fixes bug 755606 and bug 759190 too.
Assignee | ||
Updated•11 years ago
|
Assignee | ||
Comment 1•11 years ago
|
||
I had already an implementation, but after talking at FOSDEM with Irakli we decided to try another approach, that I'm close to finish.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → zer0
Priority: -- → P1
Assignee | ||
Comment 2•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #721850 -
Flags: feedback?(rFobic)
Assignee | ||
Comment 3•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•11 years ago
|
Attachment #723734 -
Flags: review?(rFobic)
Updated•11 years ago
|
Attachment #723734 -
Flags: review?(rFobic) → review+
Comment 4•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/62ce3339c514c1fc097ff355957081c0027f3bea Merge pull request #848 from ZER0/method Bug 837494 - re-implement `contentStyle*` using the new nsIDOMWindowUtils methods r=@gozala
This is fixed, right?
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 6•11 years ago
|
||
No is not. Waiting for Irakli's feedback about the implementation, and then creates a review about it. I hope he'll able to take a look soon.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Updated•11 years ago
|
Attachment #721850 -
Flags: feedback?(rFobic) → feedback-
Assignee | ||
Updated•11 years ago
|
Attachment #721850 -
Flags: feedback- → review?(rFobic)
Comment 7•11 years ago
|
||
Comment on attachment 721850 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/839 So I made some remarks regarding overall design for which I can take part of blame. Although there are no changes required to an exported API, so I think you should land this change but followup with a fixes to address comments in a pull request. I also made comments on exported functions names (I DO NOT mean attach / detach) that is probably better to address before landing unless you disagree with my suggestions. If you disagree I don't have real issues with leaving names as is too.
Attachment #721850 -
Flags: review?(rFobic) → review+
Comment 8•11 years ago
|
||
To be clear in previous comment I was referring to naming inconsistencies between `loadSheet` and `removeSheet`.
Comment 9•11 years ago
|
||
Commits pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/28fb7faa9d9607c1a031cd31bc809eab28baa7d7 Bug 837494 - re-implement `contentStyle*` using the new nsIDOMWindowUtils methods - added `mod` module, with `attach`, `detach`, `attachTo`, `detachFrom` and `getWindowTarget` - added `loadSheet` and `removeSheet` to `stylesheet/utils` - added `Style` object in `stylesheet/style` - replace usage of stylesheet services with `attach`/`detach` a `Style` object - added `weak-set` module https://github.com/mozilla/addon-sdk/commit/34df9d37472166cba40ee879fcf00bd6cd972e5e Merge pull request #839 from ZER0/contentStyle/837494 fix Bug 837494 - re-implement `contentStyle*` using the new nsIDOMWindowUtils methods r=@gozala
Updated•11 years ago
|
Status: REOPENED → RESOLVED
Closed: 11 years ago → 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•