Closed Bug 837566 Opened 7 years ago Closed 6 years ago

Remove js_RemoveRoot.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla28

People

(Reporter: njn, Assigned: njn)

Details

(Whiteboard: [qa-])

Attachments

(1 file)

We don't need a friend API for removing roots, because we have a proper API for
that.
Attachment #709552 - Flags: review?(terrence)
Comment on attachment 709552 [details] [diff] [review]
Remove js_RemoveRoot.

Review of attachment 709552 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for fix this: I totally missed it when doing the API cleanup in bug 760885.
Attachment #709552 - Flags: review?(terrence) → review+
(In reply to Ryan VanderMeulen [:RyanVM] from comment #4)
> This had to be backed out for causing Linux32 mochitest-other hangs on
> shutdown.

(These weren't perma-orange, but about 70-80%, in case you get green on a try run and are puzzled)
That's surprising.  It was a small refactoring that should have had no functional change.  Looking at the patch I can't see what might have gone wrong.
Rebased and relanded:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b8051da2a530

> This had to be backed out for causing Linux32 mochitest-other hangs on
> shutdown.

I suspect this patch was blamed incorrectly.  Things were fine on try just now:
https://tbpl.mozilla.org/?tree=Try&rev=c8bb76ab49b8
https://hg.mozilla.org/mozilla-central/rev/b8051da2a530
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.