Closed
Bug 837601
Opened 12 years ago
Closed 12 years ago
Regression on grid after launching mouse support
Categories
(Firefox OS Graveyard :: Gaia::Homescreen, defect)
Tracking
(b2g18+ fixed, b2g18-v1.0.1 fixed)
RESOLVED
FIXED
People
(Reporter: crdlc, Assigned: crdlc)
References
Details
Attachments
(1 file)
188 bytes,
text/html
|
arcturus
:
review+
akeybl
:
approval-gaia-v1+
|
Details |
After landing https://bugzilla.mozilla.org/show_bug.cgi?id=836023 there is a bug here
https://github.com/mozilla-b2g/gaia/pull/7863/files#L2L53
getX(evt) instead of getX(evt).pageX
STP:
1) Go to first page
2) Launch settings app
3) Go to landing page
4) Go to first page and click on Settings app
Expected result:
Settings app should be launched
Current result:
Settings app is not launched and the grid goes to landing page
Assignee | ||
Comment 1•12 years ago
|
||
I have the patch in two minutes
Assignee: nobody → crdlc
Status: NEW → ASSIGNED
Assignee | ||
Comment 2•12 years ago
|
||
NOTE: If blocking-basecamp+ is set, just land it for now.
[Approval Request Comment]
Bug caused by (feature/regressing bug #): 836023
User impact if declined: wrong behavior
Testing completed: yes
Risk to taking this patch (and alternatives if risky): null
Attachment #709642 -
Flags: review?(francisco.jordano)
Attachment #709642 -
Flags: approval-gaia-v1?
Assignee | ||
Updated•12 years ago
|
tracking-b2g18:
--- → ?
Updated•12 years ago
|
Attachment #709642 -
Flags: review?(francisco.jordano) → review+
Assignee | ||
Comment 3•12 years ago
|
||
Merging in master while triage
https://github.com/mozilla-b2g/gaia/commit/09b098094a5157c1a4666af09d2b5c67167c2bd9
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Updated•12 years ago
|
Comment 4•12 years ago
|
||
Comment on attachment 709642 [details]
Bug fixed
Approving in support of desktop testers, given the risk evaluation here.
Attachment #709642 -
Flags: approval-gaia-v1? → approval-gaia-v1+
Comment 5•12 years ago
|
||
v1-train: 4c70b2457f04e8c24c0f98ce658aebe26eb725dd
status-b2g18:
--- → fixed
Comment 8•12 years ago
|
||
Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1
status-b2g18-v1.0.1:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•