837652 - Notifications about low balance and reaching zero appear only when requesting balance

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect)

Description

[Salvador de la Puente González [:salva]]

STR:
1 - Open Cost Control and check balance
2 - Open Cost Control settings and enable low limit alarm
3 - Set low limit to an amount 1$ below the current balance
4 - Exit Cost Control
5 - Send a SMS

Expected:
As low limit is trespassed, a notification is shown informing about it

Actual:
Nothing happen.
If you then open utility tray or Cost Control application and wait for a balance update, the notification is shown.

It makes no sense to notify when the user has checked already the balance.
This is a regression of the Cost Control refactor, before it, we have this proactive behavior.

Comment 1

[Salvador de la Puente González [:salva]]

Attachment: Checking balance when endind an outgoing call or sending a SMS

Bug caused by (feature/regressing bug #): bug #816927
User impact if declined: high
Testing completed: yes
Risk to taking this patch (and alternatives if risky): medium

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 709702 [details]
Checking balance when endind an outgoing call or sending a SMS

r=me

Comment 3

[Salvador de la Puente González [:salva]]

Landed in master:
https://github.com/mozilla-b2g/gaia/commit/c419284fe96fb4ad71a735dc81f12328697d393a

Comment 4

[Lukas Blakk [:lsblakk] use ?needinfo]

Triage marking this as tef+ since this is an important part of the cost control feature, go ahead with uplifts no approval needed.

Comment 5

[John Ford [:jhford] CET/CEST Berlin Time]

v1-train: 220b98fba0fb1885bfc8117359d2da4cf2cc011a

This patch did not apply cleanly to v1.0.0.  Please merge it to v1.0.0 manually.  You might be able to do that with this:

git checkout v1.0.0
git cherry-pick -x 220b98fba0fb1885bfc8117359d2da4cf2cc011a

Then resolve conflicts and push back to gaia

Comment 6

[Salvador de la Puente González [:salva]]

Ehm, this is caused because this bug include changes from:
https://bugzilla.mozilla.org/show_bug.cgi?id=830361
https://bugzilla.mozilla.org/show_bug.cgi?id=833784

Which are not flagged as being in v1.0.0

I checked this (but not pushed) by cherry-picking those bugs first. Then, it's possible to merge this without pain so, what do you want me to do?

1 - Cherry-pick only this bug including modifications from the bugs referred above
2 - Cherry-pick each of the above bugs and then cherry-pick this one

Comment 7

[Salvador de la Puente González [:salva]]

v1.0.0: 622809edbb2007f23a200a0564c1a834c3a45040

Comment 8

[Darren]

Created test case for this issue:
https://moztrap.mozilla.org/manage/cases/?filter-id=6931

Comment 9

[cbarker]

Unable to Verify, requires a Sim Card with an existing balance on it to test

Comment 10

[John Hammink]

Carlos - can you please check this in your environment (and with your SIM) to ensure that it's fixed.

Comment 11

[Salvador de la Puente González [:salva]]

I think the needinfo was for Carlos, not for me...

Comment 12

[Carlos Martínez Toral [:carlosmartinez]]

Verified fixed on inari device with:

Gaia commit: f2a9d8
Build identifier: 20130421003941
QC RIL: V1.01.00.01.19.072

from v1.0.1