Closed Bug 837676 Opened 7 years ago Closed 5 years ago
[video] Implement new startup loading events
46 bytes, text/x-github-pull-request
|Details | Review|
We need to measure when the app is usable by the user. For that we'll need to send an event (the moment is specific to the app) to |window| that the performance test will be able to receive. The event name can be "x-moz-perf-user-ready" amongst all apps so that the performance test can be similar. For the Video app, it should be triggered when the user can actually manipulate the app. We should measure 2 runs (cold and warm) for this app: the first run will populate the internal DB, the second run will directly load the internal DB and should be faster.
Summary: "ready to use" perf measurement → [video] "ready to use" perf measurement
Bug 996038 introduces new events outlining the phases of application startup. Each of these 5 events needs to be implemented.
Summary: [video] "ready to use" perf measurement → [video] Implement new startup loading events
Adding to sprint4 for discussion during planning
Target Milestone: --- → 2.0 S4 (20june)
As an FYI, this implementation needs to land in 2.0 as it is important for meeting release performance acceptance criteria. https://wiki.mozilla.org/FirefoxOS/Performance/Release_Acceptance
Russ, please take this one. You can take a look at this one as an example impl. https://bugzilla.mozilla.org/show_bug.cgi?id=837674 Thanks Hema
Assignee: dflanagan → rnicoletti
Target Milestone: 2.0 S4 (20june) → 2.0 S5 (4july)
Attachment #8447538 - Flags: review?(dflanagan) → review?(johu)
Comment on attachment 8447538 [details] [review] Pull request: https://github.com/mozilla-b2g/gaia/pull/21134 It looks good. Only one concern that we already have a variable called firstScanEnd which is set before all UI update. And we introduce another variable firstScanDone at this patch. Maybe, we can use local variable to keep the state and dispatch the event for it.
Attachment #8447538 - Flags: review?(johu) → review+
Thanks, John. I updated the PR to use firstScanEnded instead of introducing a new variable. Master: https://github.com/mozilla-b2g/gaia/commit/7e3aa22cf947f30512e6124d32b594e151876640
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Whiteboard: [c=automation p= s= u=] → [c=automation p= s=2014.07.04.t u=]
Russ, could you please have this uplifted to 2.0? See comment 3.
You need to log in before you can comment on or make changes to this bug.