BaselineCompiler: Compile JSOP_TOID

RESOLVED FIXED

Status

()

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jandem, Assigned: jandem)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Assignee

Description

7 years ago
No description provided.
Assignee

Comment 1

7 years ago
Posted patch PatchSplinter Review
JSOP_TOID is used for expressions like obj[idx]++, to avoid converting idx twice (observable if idx is an object). v8-crypto uses it but other than that it's not very common.

JSOP_TOID does not need its own IC, the only case IonMonkey cares about is if the input is int32, in that case TOID is a no-op. If idx is not known to be int32, Ion falls back to a VM call.
Attachment #709729 - Flags: review?(kvijayan)
Attachment #709729 - Flags: review?(kvijayan) → review+
Assignee

Comment 2

7 years ago
https://hg.mozilla.org/projects/ionmonkey/rev/419f7cb7d3f4
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.