837730 - updater does not compile on some linux platforms due to missing NULL definition

Status: RESOLVED FIXED

(Toolkit :: Application Update, defect)

Description

[Oleg Romashin (:romaxa)]

readstrings.h seem require #include <unistd.h>

c++ -o progressui_null.o -c  -fvisibility=hidden -DNO_NSPR_10_SUPPORT -DNS_NO_XPCOM -DMAR_CHANNEL_ID='""' -DMOZ_APP_VERSION='"21.0a1"'  -I/mozilla-central/toolkit/mozapps/update/updater/../common  -I/mozilla-central/toolkit/mozapps/update/updater -I. -I../../../../dist/include  -I/mozilla-central/obj-build-n9-qt/dist/include/nspr -I/mozilla-central/obj-build-n9-qt/dist/include/nss      -fPIC  -Wall -Wpointer-arith -Woverloaded-virtual -Werror=return-type -Wtype-limits -Wempty-body -Wno-invalid-offsetof -DFORCE_BASICTILEDTHEBESLAYER=1 -DEGL_HAS_BACKING_SURFACE=1 -DUSE_ANDROID_OMTC_HACKS=1 -fno-exceptions -fno-strict-aliasing -ffunction-sections -fdata-sections -fno-exceptions -std=gnu++0x -pthread -pipe  -DNDEBUG -DTRIMMED -gdwarf-2 -Os -freorder-blocks  -fno-omit-frame-pointer     -DMOZILLA_CLIENT -include ../../../../mozilla-config.h -MD -MF .deps/progressui_null.o.pp  /mozilla-central/toolkit/mozapps/update/updater/progressui_null.cpp
In file included from /mozilla-central/toolkit/mozapps/update/updater/../common/updatedefines.h:8,
                 from /mozilla-central/toolkit/mozapps/update/updater/progressui.h:10,
                 from /mozilla-central/toolkit/mozapps/update/updater/progressui_null.cpp:7:
/mozilla-central/toolkit/mozapps/update/updater/../common/readstrings.h:37: error: 'NULL' was not declared in this scope

Comment 1

[Tatiana Meshkova (:tatiana)]

Attachment: include unistd.h

Comment 2

[Tatiana Meshkova (:tatiana)]

Attachment: include unistd.h

Comment 3

[Robert Strong (they/them - no direct email)]

Comment on attachment 713103 [details] [diff] [review]
include unistd.h

I think the following outside of the existing #else block is cleaner and already used extensively throughtout the code

http://mxr.mozilla.org/mozilla-central/source/media/webrtc/trunk/webrtc/common_types.h#30

http://mxr.mozilla.org/mozilla-central/search?string=%23ifndef%20NULL

Comment 4

[Tatiana Meshkova (:tatiana)]

Attachment: define NULL 0

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0d4d1aca6c29

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/0d4d1aca6c29