Closed Bug 837842 Opened 10 years ago Closed 10 years ago

WMFByteStream::GetCapabilities() could not return MFBYTESTREAM_IS_PARTIALLY_DOWNLOADED when the MediaResource is cached

Categories

(Core :: Audio/Video, defect)

Product:
Core
Component:
Audio/Video
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla21

People

(Reporter: cpearce, Assigned: cpearce)

References

Details

Attachments

(1 file)

Patch
1.16 KB, patch
padenot
: review+
Details | Diff | Splinter Review 
As per bug 836927 comment 3, we should consider changing WMFByteStream::GetCapabilities() to return MFBYTESTREAM_IS_PARTIALLY_DOWNLOADED only when !mResource->IsCachedToEndOfStream(0).
I tested this change, it looks like it doesn't regress on Try, or regress bug 824877:
https://tbpl.mozilla.org/?tree=Try&rev=1fcd39184600
Attached patch Patch — — Splinter Review 
* Don't report MBYTESTREAM_IS_PARTIALLY_DOWNLOADED in WMFByteStream::GetCapabilities() when !mResource->IsDataCachedToEndOfResource(0).
Attachment #711562 - Flags: review?(paul)
Comment on attachment 711562 [details] [diff] [review]
Patch

Review of attachment 711562 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #711562 - Flags: review?(paul) → review+
https://hg.mozilla.org/mozilla-central/rev/1ff7a764c2a9
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.