Closed
Bug 837842
Opened 13 years ago
Closed 13 years ago
WMFByteStream::GetCapabilities() could not return MFBYTESTREAM_IS_PARTIALLY_DOWNLOADED when the MediaResource is cached
Categories
(Core :: Audio/Video, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: cpearce, Assigned: cpearce)
References
Details
Attachments
(1 file)
|
1.16 KB,
patch
|
padenot
:
review+
|
Details | Diff | Splinter Review |
As per bug 836927 comment 3, we should consider changing WMFByteStream::GetCapabilities() to return MFBYTESTREAM_IS_PARTIALLY_DOWNLOADED only when !mResource->IsCachedToEndOfStream(0).
|
Assignee | |
Comment 1•13 years ago
|
||
I tested this change, it looks like it doesn't regress on Try, or regress bug 824877:
https://tbpl.mozilla.org/?tree=Try&rev=1fcd39184600
|
|
Assignee | |
Comment 2•13 years ago
|
||
* Don't report MBYTESTREAM_IS_PARTIALLY_DOWNLOADED in WMFByteStream::GetCapabilities() when !mResource->IsDataCachedToEndOfResource(0).
Attachment #711562 -
Flags: review?(paul)
|
||
Comment 3•13 years ago
|
||
Comment on attachment 711562 [details] [diff] [review]
Patch
Review of attachment 711562 [details] [diff] [review]:
-----------------------------------------------------------------
Thanks!
Attachment #711562 -
Flags: review?(paul) → review+
|
|
Assignee | |
Comment 4•13 years ago
|
||
|
||
Comment 5•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•