837850 - Create multiple b2g partner/release flag field:values

Status: RESOLVED WONTFIX

(bugzilla.mozilla.org :: Administration, task)

Description

[Lukas Blakk [:lsblakk] use ?needinfo]

Attachment: mockup of bug view and edit mode for new b2g flags: multi selection

See the attached mockup. In part similar to how the Autoland box was created, can we have a two-view representation of what is being tracked for b2g.

In bug view mode, the partner names and if status is ? or + is viewable all on one line (though there should be testing on how many partner codenames can be accomodated, perhaps have the ability to split to two lines for >4 names?)

Then in the edit mode, a multi-selection box appears that show what the current (if any) selection is for a partner name - this should be a radio button series per partner name so only one of ?, +, - is available to each row in the table.

As with other tracking flags, we'd need + and - to only be set by the drivers group (currently killimanjaro-drivers I believe it's called).

Thank you and please let myself or Alex Keybl know the eta on this request as well as any questions or concerns we need to iron out.

Comment 1

[Lukas Blakk [:lsblakk] use ?needinfo]

Forgot to mention, in the bug view (non-edit) we should only see the partner names who have either a ? or a + set for them.  No need to show the - or not set at all.

Comment 2

[David Lawrence [:dkl]]

(In reply to Lukas Blakk [:lsblakk] from comment #0)
> Then in the edit mode, a multi-selection box appears that show what the
> current (if any) selection is for a partner name - this should be a radio
> button series per partner name so only one of ?, +, - is available to each
> row in the table.

Is there a reason it needs to be radio buttons as opposed to a simple drop-down field like the other current tracking flags? Breaking out the b2g flags into their own section is not too difficult but converting just those to radios will add additional complexity on the backend. 

Just curious if the radio buttons are a hard requirement.

dkl

Comment 3

[Lukas Blakk [:lsblakk] use ?needinfo]

Does not need to be radio buttons, totally understand that this would make it more complex, I just thought it looked pretty in the mockup.  Pull downs work, as long as those can be populated with the - (minus) status if that has been set on a particular partner's pulldown, but not show in the non-edit view.  Does that part make sense?

Comment 4

[David Lawrence [:dkl]]

(In reply to Lukas Blakk [:lsblakk] from comment #3)
> Does not need to be radio buttons, totally understand that this would make
> it more complex, I just thought it looked pretty in the mockup.  Pull downs
> work, as long as those can be populated with the - (minus) status if that
> has been set on a particular partner's pulldown, but not show in the
> non-edit view.  Does that part make sense?

Yeah shouldn't be a problem.

dkl

Comment 5

[David Lawrence [:dkl]]

After having a discussion about this and the impact it would have on BMO, we have decided that we would like to see if we can push this off for a short bit to allow time for a new feature to be implemented. 

We have an extension that we wrote not too long ago that will allow us to move all of the tracking/project flags out of the bugs table and into separate mapping tables to allow better performance and future growth. The number of tracking flags, due to rapid release, etc., will continue to grow and the current method for adding them is not technically substainable. 

We were originally thinking of rolling out the extension post 4.2 upgrade along with migrating all of the existing tracking/project flags to the new format. The upgrade is supposed to happen around 2-3 weeks from now with the tracking flag migration happening a week or two after. Deploying the extension itself is fairly easy and quick whereas the migration will required a major outage of Bugzilla itself as it takes a good while to do it.

The new idea, is the roll out the new extension code along with the upgrade or shortly after and go ahead and start using it for the new fields to be added before the actual migration happens later. This way any new tracking/project flags can take advantage of the new storage format while the old flags continue to work alongside. 

To this will take some additional development/testing to make the old/new work together and we don't want to do all of this for two versions of Bugzilla with 4.2 coming so soon. So that being said, we would like to implement these new b2g flags using the new extension and this will put this as being resolved in around 3-4 weeks.

Thoughts?

dkl

Comment 6

[Lukas Blakk [:lsblakk] use ?needinfo]

Getting this ability is a long-term win for us, so we'll manage with what we have for now.  3-4 weeks is do-able, hopefully it ends up being closer to 3 than to 4 :)

Will this new functionality at least maintain, if not improve, the ability to query for these flags?  We'll want to be able to do this through both the bz web search and in the REST API.

Comment 7

[David Lawrence [:dkl]]

(In reply to Lukas Blakk [:lsblakk] from comment #6)
> Getting this ability is a long-term win for us, so we'll manage with what we
> have for now.  3-4 weeks is do-able, hopefully it ends up being closer to 3
> than to 4 :)
> 
> Will this new functionality at least maintain, if not improve, the ability
> to query for these flags?  We'll want to be able to do this through both the
> bz web search and in the REST API.

The goal of the TrackingFlags extension was to maintain backward compatibility with the current tracking flags so I do not see this as being a problem with search and using the BzAPI REST proxy. The flags will basically look the same from the user's perspective yet be more efficient in the way they are stored on the backend.

I am glad to see you are able to wait for us to utilize this new feature.

For more information on the extension, see: https://wiki.mozilla.org/BMO/TrackingFlags

dkl

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Hi David - now that the update has happened, what are the next steps here?

Comment 9

[David Lawrence [:dkl]]

(In reply to Lukas Blakk [:lsblakk] from comment #8)
> Hi David - now that the update has happened, what are the next steps here?

Yes as the upgrade has just happened, we should be able to start looking at this again in the next day or so. I will get with glob to come up with a roll out plan.

dkl

Comment 10

[Alex Keybl [:akeybl]]

(In reply to David Lawrence [:dkl] from comment #9)
> (In reply to Lukas Blakk [:lsblakk] from comment #8)
> > Hi David - now that the update has happened, what are the next steps here?
> 
> Yes as the upgrade has just happened, we should be able to start looking at
> this again in the next day or so. I will get with glob to come up with a
> roll out plan.
> 
> dkl

Any updates here or suggested alternatives here? This is becoming a major issue for us, since partners are sharing a single flag per release.

Comment 11

[:glob ✱]

(In reply to Alex Keybl [:akeybl] from comment #10)
> Any updates here or suggested alternatives here? This is becoming a major
> issue for us, since partners are sharing a single flag per release.

bug 750742 (which this request depends on) is a high priority for us, and we're working hard on getting this landed.

Comment 12

[David Lawrence [:dkl]]

Sorry for the delay on this. We have completed the initial implementation of this new feature and are ready for testing. We would like for you to take a little time to test this new functionality on our test instance and give feedback and generally to make sure it does what it is supposed to do.

I need to get a list from your of the new partner flags that you originally needed so I can create them on the test system. Also I need a list of values for each of the drop downs that we will create. Lastly we would need to know which of the values should be settable by only a select group of people. 

The test instance is: https://bugzilla-dev.allizom.org/

Example dropdowns and values would be

b2g-partner1: ---, ?, +, -
b2g-partner2: ---, ?, +, -
etc.

We are able to group them together in their own B2G flag section away from the normal tracking flags. 

Please let me know as soon as you can and I can get them set up for you. Once we have completed some good testing, we will be able to roll the new code to production very soon after.

Thanks
dkl

Comment 15

[David Lawrence [:dkl]]

Ok. I have now been able to add these new fields to the Boot2Gecko product on our test instance at https://bugzilla-dev.allizom.org. Please take a bit to create some bugs under that product, make some changes, do some searching, etc. to make sure it all works properly and will also work for your needed changes for now.

Thanks
dkl

Comment 16

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #15)
> Ok. I have now been able to add these new fields to the Boot2Gecko product
> on our test instance at https://bugzilla-dev.allizom.org. Please take a bit
> to create some bugs under that product, make some changes, do some
> searching, etc. to make sure it all works properly and will also work for
> your needed changes for now.
> 
> Thanks
> dkl

Ping Lukas. Please take a moment to try out the new flag fields and let us know if you run into any issues or need changes, We are anxious to get this functionality rolled out :)

Thanks
dkl

Comment 17

[David Lawrence [:dkl]]

(In reply to David Lawrence [:dkl] from comment #16)
> (In reply to David Lawrence [:dkl] from comment #15)
> > Ok. I have now been able to add these new fields to the Boot2Gecko product
> > on our test instance at https://bugzilla-dev.allizom.org. Please take a bit
> > to create some bugs under that product, make some changes, do some
> > searching, etc. to make sure it all works properly and will also work for
> > your needed changes for now.
> > 
> > Thanks
> > dkl
> 
> Ping Lukas. Please take a moment to try out the new flag fields and let us
> know if you run into any issues or need changes, We are anxious to get this
> functionality rolled out :)
> 
> Thanks
> dkl

Sorry to ping again.

dkl

Comment 18

[David Lawrence [:dkl]]

FWIW. these flags have not been enabled and are present on the production system for all B2G bug reports. Please let me know how they look and work.

dkl

Comment 19

[:glob ✱]

as lukas's request i've deactivated the fields (the concern at this stage is they may cause confusion).

Comment 20

[Lukas Blakk [:lsblakk] use ?needinfo]

I've asked for these to be removed from production.  Now that we've come further in our tracking & releasing process we've got a new plan of how to get the info we need and multiple flags is not the solution.  Thank you for your patience as we hone this process and apologies for the miscommunication.