837939 - set spdy max incoming connections to 0

Status: RESOLVED FIXED

(Core :: Networking: HTTP, enhancement)

Description

[Patrick McManus [:mcmanus]]

Somewhere along the line it was clarified that TYPE_MAX_CONCURRENT spdy settings applied bidirectionally. (the other interpretation was that this was the server setting only and if sent by the client was just a persisted echo of that.)

The value in that is we can set it to 0 in the interim period while server push is not yet implemented (which I intend to do). This will prevent servers from pushing streams at us. (What happens now is that they push them and we cancel them, which is ok but wastes a bunch of incoming bandwidth). I talked to a couple of folks this week who are looking to deploy push on the server side, so this will help.

Comment 1

[Patrick McManus [:mcmanus]]

Attachment: patch 0

Comment 2

[Honza Bambas (:mayhemer)]

Comment on attachment 709962 [details] [diff] [review]
patch 0

Review of attachment 709962 [details] [diff] [review]:
-----------------------------------------------------------------

r=honzab

BTW, do we implement (honor) the limit on our side when the server sent some number in its settings?

Comment 3

[Patrick McManus [:mcmanus]]

> 
> BTW, do we implement (honor) the limit on our side when the server sent some
> number in its settings?

yes, and its pretty well tested as one of the google services sets it to 10 (the default is 100).

Comment 4

[Patrick McManus [:mcmanus]]

remote:   https://hg.mozilla.org/integration/mozilla-inbound/rev/6124f1fc8e3a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6124f1fc8e3a