838024 - [Captive Portal] Need an icon for captive portal notification

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[(inactive after 6/18) Alive Kuo [:alive]]

Spec: http://people.mozilla.com/~lco/Captive_Portal_B2G/R1.1_Captive%20Portal%20spec%20v1%20DRAFT.pdf

Now we don't have any icon for captive portal, this makes the notification looks strange. In normal case the notification would have the app icon who calls for it, but in this case the caller app is system app.

Comment 1

[Joe Cheng [:jcheng] (please needinfo)]

:patryk, can you please provide this? thanks

Comment 2

[Patryk Adamczyk [:patryk] UX]

Peter can you take this? It will likely be app icon style.

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

pla: do you think you can give some updates on this bug? thanks

Comment 4

[Peter La]

Hi, i'll be creating this icon today.

Comment 5

[Peter La]

Attachment: Captive Portal Icon + Screenshot

Use the 30x30 version.  See screenshot for reference.

Comment 6

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/8002

Tim, this patch simply adds the icon. Could you help review it? Thanks.

Comment 7

[Arthur Chen [:arthurcc][inactive after 6/30]]

Landed to master. https://github.com/mozilla-b2g/gaia/commit/96b2c3ce08b4800e43c0be001b17b7e2f5bd186b
Landed to v1-train. https://github.com/mozilla-b2g/gaia/commit/7e54ca673277b20b1d91d18477dc44d6ad226761

Thank you tim!

Comment 8

[Lukas Blakk [:lsblakk] use ?needinfo]

Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1

Comment 9

[Askeing Yen[:askeing][:fyen]]

Unagi
Gaia:     819afb8758de9fbf87eca837e328818de93307ec
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/96f559f949bb
BuildID   20130402230203
Version   18.0

Verified.