[Captive Portal] Need an icon for captive portal notification

VERIFIED FIXED

Status

VERIFIED FIXED
6 years ago
6 years ago

People

(Reporter: alive, Assigned: arthurcc)

Tracking

unspecified
ARM
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:shira+, b2g18 fixed, b2g18-v1.0.1 fixed)

Details

(Whiteboard: QARegressExclude)

Attachments

(2 attachments)

Spec: http://people.mozilla.com/~lco/Captive_Portal_B2G/R1.1_Captive%20Portal%20spec%20v1%20DRAFT.pdf

Now we don't have any icon for captive portal, this makes the notification looks strange. In normal case the notification would have the app icon who calls for it, but in this case the caller app is system app.
:patryk, can you please provide this? thanks
Assignee: nobody → padamczyk
blocking-b2g: shira? → shira+
Peter can you take this? It will likely be app icon style.
Assignee: padamczyk → pla
pla: do you think you can give some updates on this bug? thanks

Comment 4

6 years ago
Hi, i'll be creating this icon today.

Comment 5

6 years ago
Created attachment 710905 [details]
Captive Portal Icon + Screenshot

Use the 30x30 version.  See screenshot for reference.
Assignee: pla → arthur.chen
Created attachment 711179 [details]
Link to https://github.com/mozilla-b2g/gaia/pull/8002

Tim, this patch simply adds the icon. Could you help review it? Thanks.
Attachment #711179 - Flags: review?(timdream)
Attachment #711179 - Flags: review?(timdream) → review+
Landed to master. https://github.com/mozilla-b2g/gaia/commit/96b2c3ce08b4800e43c0be001b17b7e2f5bd186b
Landed to v1-train. https://github.com/mozilla-b2g/gaia/commit/7e54ca673277b20b1d91d18477dc44d6ad226761

Thank you tim!
Status: NEW → RESOLVED
Last Resolved: 6 years ago
status-b2g18: --- → fixed
Resolution: --- → FIXED
Batch edit: bugs fixed on b2g18 since 1/25 branch of v1.0 are fixed on v1.0.1
status-b2g18-v1.0.1: --- → fixed

Updated

6 years ago
Whiteboard: QARegressExclude
Unagi
Gaia:     819afb8758de9fbf87eca837e328818de93307ec
Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/96f559f949bb
BuildID   20130402230203
Version   18.0

Verified.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.