838051 - [Contacts][User Story] GMail contact import

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Description

[Peter Dolanjski [:pdol]]

UCID: Contacts-002

User Story:
As a user, I want to be able to import my contacts from GMail so that I can easily connect with my friends without manually adding contacts.

Comment 1

[[:fabrice] Fabrice Desré]

Francisco, do you think you could reuse some of the code from your gmail importer?

Comment 2

[Francisco Jordano [:arcturus] [:francisco]]

Hi Frabrice,

Yes, so far we could reuse the js importing code and adapt it to the specific flow on contacts or FTU.

My only concerns are:
- Current code is using OAuth 1.0, so we will need to ask for an official api key to identify the developer (Moz in this case)
- As you know, while performing OAuth dance, once performed the authorisation in the service provider we will need to redirect to a callback url (app protocol is not allowed), but there is nothing we didn't solve in the facebook integration or in the google importer.

So basically YES :D

Comment 3

[Chris Lord [:cwiiis]]

May I suggest that this be synchronisation rather than just import? We already have Google calendar sync, and support for checking Google Mail, it makes sense to synchronise contacts too. This would be great for anyone that uses Google services, and for people migrating from Android.

Comment 4

[Casey Yee]

(In reply to Chris Lord [:cwiiis] from comment #3)
> May I suggest that this be synchronisation rather than just import? We
> already have Google calendar sync, and support for checking Google Mail, it
> makes sense to synchronise contacts too. This would be great for anyone that
> uses Google services, and for people migrating from Android.

+1 For this.
Without a proper sync any changes to contacts made on these services post-import will not be reflected on the phones contacts list.   

Unfortunately this has been deemed OOS for LEO.

Comment 5

[Casey Yee]

First draft IxD for contact import has been posted to:
https://www.dropbox.com/s/vvl7fx24iuv6qxg/contacts-import-130122.pdf

The UX basically reflects what is already in place for Facebook contacts import.

Any comment welcome!

Comment 7

[ayman maat :maat]

Reviewing wireframes.

Comment 8

[Dylan Oliver [:doliver]]

Clearing tracking-b2g18 flag from User Story bugs. This flag is for bugs that we would take fixes for in the 1.x branch. Feature work should be officially slotted into a release instead with leo+. If this story is intended for v1.1, please nominate for leo? blocking.

Comment 9

[Dylan Oliver [:doliver]]

Daniel, this should be leo+, correct?

Comment 10

[Daniel Coloma:dcoloma]

(In reply to Dylan Oliver [:doliver] from comment #9)
> Daniel, this should be leo+, correct?

correct!

Comment 11

[Peter Dolanjski [:pdol]]

Raising the priority and blocking flag based on partner conversations.

Comment 12

[Dietrich Ayala (:dietrich)]

Fancisco, can you provide an estimate of when this will be completed?

Comment 13

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Dietrich Ayala (:dietrich) from comment #12)
> Fancisco, can you provide an estimate of when this will be completed?

Hi Dietrich, the support already landed on master, but we still are pending to apply the latest UX changes, like correct icons and perhaps some UX modifications.

But if you wanna try, just launch the FTU from the settings app, you should be able to see now the import from google.

Cheers!

Comment 14

[Dylan Oliver [:doliver]]

(In reply to Francisco Jordano [:arcturus] from comment #13)
> 
> But if you wanna try, just launch the FTU from the settings app, you should
> be able to see now the import from google.

Great! Successfully imported 200 contacts from google in ~90 sec.

Comment 15

[Dietrich Ayala (:dietrich)]

Cool, can this be marked fixed, and file followups for the polish parts?

Comment 16

[jachen]

Putting needs info for Patryk's team to work with TEF and review.

Comment 17

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Dietrich Ayala (:dietrich) from comment #15)
> Cool, can this be marked fixed, and file followups for the polish parts?

Hi Dietrich, we are not marking as fixed cause we still land the integration of this import in the contacts settings, we are close to land it, will be done by 15th of March.

I agree that if we find any problems or want to add extra things, we can do it in follow ups.

Cheers.

Comment 18

[Chris Lord [:cwiiis]]

Is there a bug filed for contact sync instead of import?

Comment 19

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Chris Lord [:cwiiis] from comment #18)
> Is there a bug filed for contact sync instead of import?

Hi Chris, so far this US is for importing, as we agreed that was what we could have completed for v1.0.1 by March 15th. 

I'm sure that support will land, perhaps in master later.

Cheers,
F.

Comment 20

[Chris Lord [:cwiiis]]

(In reply to Francisco Jordano [:arcturus] from comment #19)
> (In reply to Chris Lord [:cwiiis] from comment #18)
> > Is there a bug filed for contact sync instead of import?
> 
> Hi Chris, so far this US is for importing, as we agreed that was what we
> could have completed for v1.0.1 by March 15th. 
> 
> I'm sure that support will land, perhaps in master later.
> 
> Cheers,
> F.

right, that's cool - should I file a separate bug for Google contact sync?

Comment 21

[Francisco Jordano [:arcturus] [:francisco]]

(In reply to Chris Lord [:cwiiis] from comment #20)
> 
> right, that's cool - should I file a separate bug for Google contact sync?

Sure :) let's track it.

Thanks!
F.

Comment 22

[Jason Smith [:jsmith]]

TEF is covering testing of this I believe.

Isabel - Are you covering generating test case coverage for this?

Comment 23

[Maria Angeles Oteo (:oteo)]

The testing of this US is owned by TEF team, they are preparing the test plan for it

Comment 24

[Francisco Jordano [:arcturus] [:francisco]]

Wit latest bug 848820 resolved we can close this meta bug :) \o/

Comment 25

[John Ford [:jhford] CET/CEST Berlin Time]

per bug 848820#c26, we are fixed on v1-train

Comment 26

[Natalya Kot [:nkot]]

Verifying  - the user is now able to import GMail contacts successfully during FTU and from the Contacts app

Leo build info:
Gecko  http://hg.mozilla.org/releases/mozilla-b2g18/rev/29933d1937db
Gaia   1436e2778b90bd74635b0b94d1cf8ccb0d71b60c
Build  20130625070217
Version 18.1