Reenable decodeAudioData tests

RESOLVED FIXED in mozilla22

Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: roc, Assigned: Ehsan)

Tracking

18 Branch
mozilla22
x86_64
Windows 7
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

699.63 KB, patch
roc
: review+
Details | Diff | Splinter Review
These tests are currently sensitive to the sample rate of the AudioContext. It would be nice to make them independent of the sample rate, or else at least support a variety of sample rates.
(Assignee)

Comment 1

6 years ago
Created attachment 719176 [details] [diff] [review]
WIP

Currently testing on try...
(Assignee)

Comment 3

6 years ago
Created attachment 719456 [details] [diff] [review]
Patch (v1)
Attachment #719176 - Attachment is obsolete: true
Attachment #719456 - Flags: review?(roc)
Comment on attachment 719456 [details] [diff] [review]
Patch (v1)

Review of attachment 719456 [details] [diff] [review]:
-----------------------------------------------------------------

Can you add something to make the tests automatically todo if the sample rate isn't 44100?
Attachment #719456 - Flags: review?(roc) → review+
(Assignee)

Comment 5

6 years ago
Sure (assuming you mean 48000).
https://hg.mozilla.org/mozilla-central/rev/6bd0ba602b8a
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla22
You need to log in before you can comment on or make changes to this bug.