Closed Bug 838079 Opened 9 years ago Closed 9 years ago

get memtest.py on mozbase or kill it

Categories

(Testing :: Mozbase, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
mozilla21

People

(Reporter: k0scist, Assigned: k0scist)

Details

Attachments

(1 file)

http://hg.mozilla.org/mozilla-central/file/2360c3c46aca/testing/tests/memtest.py

A few things:

* I'm not sure if this file is used or not.  Casual MXRing suggests
  not.  If this is the case, we should just kill the testing/tests
  directory

* Speaking of, testing/tests is an awful name for where this is.
  Let's put it somewhere better if we keep it.  I suggest
  testing/memtest

* Also, if there was a README I'd probably have a better idea if it
  was still relevent.  If we keep it, lets add a README

* And some docstrings and other in-code documentation

* There is some overlap between this file and mozbase: Firefox_runner,
  etc. We should make use of the relevent mozbase software for this.

* And let's change the shebang to /usr/bin/env python

* Instead of having a main section delimited by comments,
  http://hg.mozilla.org/mozilla-central/file/2360c3c46aca/testing/tests/memtest.py#l431
  , lets have a main function that is called if __name__ == '__main__'

*
  http://hg.mozilla.org/mozilla-central/file/2360c3c46aca/testing/tests/memtest.py#l445
  : to mozprocess if its worth it
Really a question to anyone but can this be killed?
Flags: needinfo?(ted)
Attached patch remove itSplinter Review
ted informed me that this file is obselete
Flags: needinfo?(ted)
Attachment #713012 - Flags: review?(ted)
Attachment #713012 - Flags: review?(ted) → review+
thanks, ted.  pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0780ca1d62d4
https://hg.mozilla.org/mozilla-central/rev/0780ca1d62d4
Assignee: nobody → jhammel
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.