Closed
Bug 838079
Opened 13 years ago
Closed 13 years ago
get memtest.py on mozbase or kill it
Categories
(Testing :: Mozbase, defect)
Testing
Mozbase
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla21
People
(Reporter: k0scist, Assigned: k0scist)
Details
Attachments
(1 file)
|
17.57 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
http://hg.mozilla.org/mozilla-central/file/2360c3c46aca/testing/tests/memtest.py
A few things:
* I'm not sure if this file is used or not. Casual MXRing suggests
not. If this is the case, we should just kill the testing/tests
directory
* Speaking of, testing/tests is an awful name for where this is.
Let's put it somewhere better if we keep it. I suggest
testing/memtest
* Also, if there was a README I'd probably have a better idea if it
was still relevent. If we keep it, lets add a README
* And some docstrings and other in-code documentation
* There is some overlap between this file and mozbase: Firefox_runner,
etc. We should make use of the relevent mozbase software for this.
* And let's change the shebang to /usr/bin/env python
* Instead of having a main section delimited by comments,
http://hg.mozilla.org/mozilla-central/file/2360c3c46aca/testing/tests/memtest.py#l431
, lets have a main function that is called if __name__ == '__main__'
*
http://hg.mozilla.org/mozilla-central/file/2360c3c46aca/testing/tests/memtest.py#l445
: to mozprocess if its worth it
| Assignee | ||
Comment 1•13 years ago
|
||
Really a question to anyone but can this be killed?
Flags: needinfo?(ted)
| Assignee | ||
Comment 2•13 years ago
|
||
| Assignee | ||
Comment 3•13 years ago
|
||
pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=aee04d0eeff0
| Assignee | ||
Updated•13 years ago
|
Attachment #713012 -
Flags: review?(ted)
Updated•13 years ago
|
Attachment #713012 -
Flags: review?(ted) → review+
| Assignee | ||
Comment 5•13 years ago
|
||
thanks, ted. pushed to inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/0780ca1d62d4
Comment 6•13 years ago
|
||
Assignee: nobody → jhammel
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•