838139 - [Email] "Mail To: "Email" " string is truncated when we select an email id from the body of email message

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Leo]

1. Title : "Mail To: "Email" " string is truncated when we select an email id from the body of email message.
2. Precondition : Email should be working and has the email with "email id" as a text in the body of the email. For Ex: [e-mail] is part of the body of email.
3. Tester's Action : Email-Open an email which contains email id in the body of the email.
4. Detailed Symptom (ENG.) : For the email selected it is showing "Browse to URL" and Email id is cut in the end.
5. Expected :Browse to URL may be not required for the email id and email should be shown properly without any truncation.
6.Reproducibility: Y
1)Frequency Rate : 100%
7.Gaia Revision: f46757775e07d314913b4a5ae975fa131d1c7c4b

Comment 1

[Andrew Sutherland [:asuth] (he/him)]

To re-state my understanding, the detection of e-mail address links works, the problem is on the "Browse to URL?:" confirmation screen when one clicks on the e-mail address or any other link.  Specifically, when the e-mail address is wider than the screen, it sounds like the e-mail address goes off the edge of the screen and is not wrapping for you.

What should be happening is the text should be wrapping.

Can you provide a screenshot of both the incorrect confirmation screen and of the message that triggered the problem?  It's conceivable the message might be causing some DOM node to grow in ways it should not.

Comment 2

[Leo]

Attachment: Large Email ID is not Visible

When we click on Large email ID from email body it is not visible completely.

Comment 3

[Leo]

Image is attached. It shows the email id which is large is not shown completely.

Comment 4

[Leo]

Attachment: Pointer to Pull request

Please check the pull request

Comment 5

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 719446 [details]
Pointer to Pull request

Thanks for the patch.  I think what we really want is "word-wrap: break-word" which should already be happening, so I looked into it more and it seems like there is a bug in the system app related to modal dialogs.  Please see my comment at:
https://bugzilla.mozilla.org/show_bug.cgi?id=818047#c5

If you can help fix that bug, that might be the ideal thing, or we can change this bug to use our ConfirmDialog helper, but I'd like the feedback from dev-gaia on what we should really be doing.

Comment 6

[Leo]

HI Andrew,

Did you get any information on using ConfirmDialog Helper for this issue from dev-gaia? Please let us know.

Thanks,
Leo

Comment 7

[Andrew Sutherland [:asuth] (he/him)]

(In reply to leo.bugzilla.gaia from comment #6)
> Did you get any information on using ConfirmDialog Helper for this issue

For posterity, the replies can be found here:
https://groups.google.com/d/topic/mozilla.dev.gaia/v6lAlGc-Riw/discussion

My original message, which google groups has confusingly not threaded together with those, can be found here:
https://groups.google.com/d/topic/mozilla.dev.gaia/k7bqiQlLRvw/discussion


The take-away points seem to be:
- We/someone should fix bug 818047
- In e-mail, we're probably better off just using our ConfirmDialog helper.

As such, if you'd like to provide a patch that just uses ConfirmDialog, that's probably the easiest/simplest/best solution for e-mail specifically.  Thanks!

Comment 8

[Leo]

Attachment: Pointer to Pull request

Hi Andrew,

Thanks for your detailed information.
We have implemented email Browse to URL Confirmation dialog using helper form in email app only. Please review the attached patch.

Thanks,
Leo

Comment 9

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 721080 [details]
Pointer to Pull request

Works great, thanks for the patch!

Landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/8457

Comment 10

[Andrew Sutherland [:asuth] (he/him)]

I think should already be on v1-train because of the bulk uplift on bug 851124.

Comment 11

[Joe Cheng [:jcheng] (please needinfo)]

triage: leo+ as users cannot read the whole email address

Comment 12

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 3d6913ff846023a0b774bdd71aa7fae3904a9f2e
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 13

[John Ford [:jhford] CET/CEST Berlin Time]

I was not able to uplift this bug to v1-train.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1-train
  git cherry-pick -x -m1 3d6913ff846023a0b774bdd71aa7fae3904a9f2e
  <RESOLVE MERGE CONFLICTS>
  git commit

Comment 14

[Alex Keybl [:akeybl]]

Andrew - can you help jhford out with comment 13?

Comment 15

[Andrew Sutherland [:asuth] (he/him)]

(In reply to Alex Keybl [:akeybl] from comment #14)
> Andrew - can you help jhford out with comment 13?

I have verified my theory from comment 10 that this was already uplifted as part of our bulk v1-train/v1.0.1 uplift on bug 851124.  Flags updated.

Comment 16

[Deepa Subramanian]

The issue does not repro anymore. The Strings are wrapped and are not truncated.

Tested on Leo and Inari device
Leo Build ID: 20130426070204
Kernel Date: Mar 15
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/6c2493de1441
Gaia: c9046a7acef33328977840176ff5574720d2c74c

Inari Build ID: 20130430070201
Kernel Date: Feb 21
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/010498e599a7
Gaia: de0f1fc6c58616b8a33fca482f1f8684d4e74e9e