Closed Bug 838177 Opened 7 years ago Closed 7 years ago

Add more debugging output to GeckoEditable and GeckoInputConnection

Categories

(Firefox for Android :: Keyboards and IME, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 21

People

(Reporter: jchen, Assigned: jchen)

Details

Attachments

(1 file, 1 obsolete file)

I've been keeping a patch of additional logging for IME because what's currently available is not adequate for testing many bugs. Time to integrate the additional logging. Should also including logging related to Bug 832028.
More logging, including when we are blocking a thread, all inside if(DEBUG)'s. Also removed redundant method in DebugGeckoInputConnection and changed to using corresponding method in GeckoEditable.
Attachment #714599 - Flags: review?(cpeterson)
Forgot to include some stuff.
Attachment #714599 - Attachment is obsolete: true
Attachment #714599 - Flags: review?(cpeterson)
Attachment #714600 - Flags: review?(cpeterson)
Comment on attachment 714600 [details] [diff] [review]
Add more debugging output to GeckoEditable and GeckoInputConnection (v2)

Review of attachment 714600 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

::: mobile/android/base/GeckoEditable.java
@@ +24,5 @@
>  import android.util.Log;
>  
>  import java.lang.reflect.InvocationHandler;
>  import java.lang.reflect.InvocationTargetException;
> +import java.lang.reflect.Field;

imports should be listed alphabetically within each block, so `java.lang.reflect.Field` should be listed before `java.lang.reflect.InvocationHandler`.
Attachment #714600 - Flags: review?(cpeterson) → review+
Addressed review comment.

https://hg.mozilla.org/integration/mozilla-inbound/rev/cf0437ccd013
Target Milestone: --- → Firefox 21
https://hg.mozilla.org/mozilla-central/rev/cf0437ccd013
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.