838222 - Work - Keep the navigation appbar visible after page load, until the user dismisses it

Status: RESOLVED FIXED

(Firefox for Metro Graveyard :: Browser, defect)

Description

[Matt Brubeck (:mbrubeck)]

Attachment: patch

According to the story in attachment 709174 [details] steps 8-9, the navigation bar should still be visible after loading a page from the urlbar/autocomplete screen.

This currently works correctly in some cases but not others, depending on whether the ContextUI._visible state variable is in sync with the "visible" attribute on the #tray element (which it isn't, at startup).

This patch gets rid of the _visible and _expanded variables, and removes the call to auto-dismiss the appbar on page load.

It also does some minor cleanup to replace [visible="true"] with [visible] in browser.css, only because I find the latter easier to read when the selectors start getting complicated.

Comment 1

[Matt Brubeck (:mbrubeck)]

Attachment: patch v2

No actual changes; just rebased to elm tip.

Comment 2

[Sam Foster [:sfoster] (he/him)]

Comment on attachment 710469 [details] [diff] [review]
patch v2

Review of attachment 710469 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good. The is* properties are an improvement and I'll keep any eye out for where I might be using attributename=true (vs. presence of attribute) - it ends up cleaner and is less ambiquous/error-prone (what with string "false" being truthy).

One thing I notice testing this is that if you edit in the location bar while a page is loading, the autocomplete screen pops in. that's the right thing I guess, but as we fill the whole screen with it vs. the dropdown in desktop its a bit jarring. I wonder if we might want to animate in. (Though, our animations are so stuttery right now maybe the less the better)

Comment 3

[Matt Brubeck (:mbrubeck)]

http://hg.mozilla.org/projects/elm/rev/d724a4556c03

Comment 4

[juan becerra [:juanb]]

Checking to see if there are existing tests, otherwise we will request in-qa-testsuite for triage.