Closed
Bug 838233
Opened 11 years ago
Closed 11 years ago
Convert HTMLHRElement to WebIDL
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: baku, Assigned: baku)
References
(Blocks 1 open bug)
Details
Attachments
(2 files, 4 obsolete files)
|
18.44 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
|
6.62 KB,
patch
|
baku
:
review+
|
Details | Diff | Splinter Review |
Let's start with something easy.
|
||
Updated•11 years ago
|
Blocks: ParisBindings, 826738
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #710299 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #710300 -
Flags: review?(peterv)
|
|
||
Comment 3•11 years ago
|
||
Comment on attachment 710300 [details] [diff] [review] part 2 - webidl Review of attachment 710300 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/HTMLHRElement.h @@ +51,5 @@ > + > + // WebIDL API > + void GetAlign(nsString& aAlign) > + { > + GetHTMLAttr(nsGkAtoms::align, aAlign); Nit: most likely those getters can be const ::: dom/bindings/Bindings.conf @@ +414,5 @@ > 'hasInstanceInterface': 'nsIDOMHTMLHeadingElement', > }, > > +'HTMLHRElement': { > + 'hasInstanceInterface': 'nsIDOMHTMLHRElement', Nit: four-space indentation ::: dom/webidl/HTMLHRElement.webidl @@ +3,5 @@ > + * License, v. 2.0. If a copy of the MPL was not distributed with this file, > + * You can obtain one at http://mozilla.org/MPL/2.0/. > + * > + * The origin of this IDL file is > + * http://www.whatwg.org/specs/web-apps/current-work/#the-h1,-h2,-h3,-h4,-h5,-and-h6-elements Is it, though?
|
|
Assignee | |
Comment 4•11 years ago
|
||
Attachment #710300 -
Attachment is obsolete: true
Attachment #710300 -
Flags: review?(peterv)
Attachment #710383 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 5•11 years ago
|
||
Getters from XPCOM.
Attachment #710383 -
Attachment is obsolete: true
Attachment #710383 -
Flags: review?(peterv)
Attachment #710556 -
Flags: review?(peterv)
|
|
Assignee | |
Comment 6•11 years ago
|
||
Attachment #710556 -
Attachment is obsolete: true
Attachment #710556 -
Flags: review?(peterv)
Attachment #711241 -
Flags: review?(Ms2ger)
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 711241 [details] [diff] [review] part 2 - webidl (d) Review of attachment 711241 [details] [diff] [review]: ----------------------------------------------------------------- ::: content/html/content/src/HTMLHRElement.h @@ +64,5 @@ > + bool NoShade() const > + { > + return GetBoolAttr(nsGkAtoms::noshade); > + } > + void SetNoShade(bool& aNoShade, ErrorResult& aError) bool&
Attachment #711241 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
Attachment #711241 -
Attachment is obsolete: true
Attachment #711271 -
Flags: review+
|
|
Assignee | |
Comment 9•11 years ago
|
||
Comment on attachment 710299 [details] [diff] [review] part 1 - renaming Review of attachment 710299 [details] [diff] [review]: ----------------------------------------------------------------- Do you mind to review this patch too? Thank you!
Attachment #710299 -
Flags: review?(peterv) → review?(Ms2ger)
|
|
||
Updated•11 years ago
|
Attachment #710299 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Updated•11 years ago
|
Keywords: checkin-needed
|
||
Comment 10•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/28418193e701 https://hg.mozilla.org/integration/mozilla-inbound/rev/d8cb965cbce5
Flags: in-testsuite?
Keywords: checkin-needed
|
|
||
Comment 11•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/28418193e701 https://hg.mozilla.org/mozilla-central/rev/d8cb965cbce5
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•