Closed
Bug 838280
Opened 11 years ago
Closed 11 years ago
Add function names and comments.
Categories
(Toolkit :: Telemetry, defect)
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: espindola, Assigned: espindola)
Details
Attachments
(1 file)
|
1.26 KB,
patch
|
froydnj
:
review+
|
Details | Diff | Splinter Review |
Anonymous functions do seem more common in mozilla-central when setting prototype fields, but yes, it looks like we need names to get good stacks.
Attachment #710312 -
Flags: review?(vdjeric)
|
||
Comment 1•11 years ago
|
||
Comment on attachment 710312 [details] [diff] [review] patch I think the commonness of anonymous functions is a relic of The Way Things Used To Be; the new style is to name everything (and rightly so, I think).
Attachment #710312 -
Flags: review?(vdjeric) → review+
|
Assignee | |
Comment 2•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2e70586576b9
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2e70586576b9
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in
before you can comment on or make changes to this bug.
Description
•