If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

make addon-builder-helper an example add-on so that tests are included with the add-on sdk

RESOLVED INVALID

Status

Add-on SDK
General
P2
normal
RESOLVED INVALID
5 years ago
4 years ago

People

(Reporter: erikvold, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

If we make the addon-builder-helper a submodule in the add-on sdk's examples folder then the tests will be included when we run `cfx test` or `cfx testex` and we know when we break it sooner.
Created attachment 710483 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/766

Pointer to Github pull-request
Attachment #710483 - Flags: review?(rFobic)
Assignee: nobody → evold
Target Milestone: --- → 1.14
Target Milestone: 1.14 → ---
Dave, in order to have this work on tinderbox I think we'd have to update tinderbox to do something like `git submodule init` then `git submodule update` after `git pull mozilla master` in whatever task updates tinderbox before launching the tests.  I'm not sure what that involves.
Flags: needinfo?(dtownsend+bugmail)
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #2)
> Dave, in order to have this work on tinderbox I think we'd have to update
> tinderbox to do something like `git submodule init` then `git submodule
> update` after `git pull mozilla master` in whatever task updates tinderbox
> before launching the tests.  I'm not sure what that involves.

Tinderbox doesn't touch git at all.

The Jetpack tinderbox tree relies on a VM cloning git into hg: https://hg.mozilla.org/projects/addon-sdk.

The main m-c tinderbox relies on us uplifting code, currently roughly described here: https://wiki.mozilla.org/Jetpack/Integration_Process
Flags: needinfo?(dtownsend+bugmail)
Well that's too bad, the test still pass without the submodule being checked out though so tinderbox wouldn't fail with this patch, and I still think it'd be useful to have tested when we manually run tests.
(In reply to Erik Vold [:erikvold] [:ztatic] from comment #4)
> Well that's too bad, the test still pass without the submodule being checked
> out though so tinderbox wouldn't fail with this patch, and I still think
> it'd be useful to have tested when we manually run tests.

Well I'm saying that if we update the instructions for landing in m-c then we can do that there. If we make whatever change we need to include the submodule in the hg repo (assuming it's possible) then we could do it there too.

Updated

5 years ago
Priority: -- → P2
Comment on attachment 710483 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/766

Most of the projects I've being involved with that used sub-modules have being pain to work on, due to special check-out instructions and additional work for keeping sub-modules in sync. I think this will make it harder to contribute to the project.

If it's just about testing, I think we could just patch test scripts to checkout addon-builder-helper into examples to include it into tests.
Attachment #710483 - Flags: review?(rFobic) → feedback-
Assignee: evold → nobody
Addon Builder is riding into sunset, so this is now moot.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.