838459 - Add printing of current timestamp to make-platformini.py

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v1

mbrubeck pointed me to where the Android makefiles call out to make-platformini to get a build ID, which they then increment to get an increasing version number. Hacky, but hey.

This code already uses Python to manipulate dates, so it seems like a reasonable place to hang something I need right now: a portable way to get the current Unix timestamp.

Recommendations for a better way to do this most welcome.

Comment 1

[Gregory Szorc [:gps]]

Comment on attachment 710485 [details] [diff] [review]
Proposed patch. v1

Review of attachment 710485 [details] [diff] [review]:
-----------------------------------------------------------------

::: toolkit/xre/make-platformini.py
@@ +19,5 @@
>  
>  (options, args) = o.parse_args()
>  
> +if options.print_timestamp:
> +    print calendar.timegm(datetime.now().timetuple())

import time
print(int(time.time()))

Much simpler and much more common. I'm not even sure what all that calendar, datetime, and timetuple foo does.

Comment 2

[Richard Newman [:rnewman]]

(In reply to Gregory Szorc [:gps] from comment #1)

> Much simpler and much more common. I'm not even sure what all that calendar,
> datetime, and timetuple foo does.

That was what the docs I found recommended :/

E_TOO_MANY_LIBRARIES

Comment 3

[Richard Newman [:rnewman]]

Attachment: Proposed patch. v2

Comment 4

[Gregory Szorc [:gps]]

Comment on attachment 710489 [details] [diff] [review]
Proposed patch. v2

Review of attachment 710489 [details] [diff] [review]:
-----------------------------------------------------------------

I can't speak for make-platformini.py being the best place for a one liner that could easily be accomplished with |python -c 'import time; print(int(time.time()))'| but meh.

Comment 5

[Richard Newman [:rnewman]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/779abebba749

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/779abebba749