838463 - make check failing in test_mozconfig.py at test_read_new_variables

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Edmund Wong (:ewong)]

Linux build's "make -k check" process errors with the following
unexpected test failure:

TEST-UNEXPECTED-FAIL | /builds/slave/c-cen-t-lnx/build/mozilla/python/mozbuild/mozbuild/test/test_mozconfig.py | line 228, test_read_new_variables: {} != {u'CC': u'/usr/local/bin/clang', u'CXX': u'/usr/local/bin/clang++'}
- {}
+ {u'CC': u'/usr/local/bin/clang', u'CXX': u'/usr/local/bin/clang++'}

Comment 1

[Gregory Szorc [:gps]]

This is very similar to bug 829664. Patch is 2 new lines to pop CC and CXX.

Comment 2

[Edmund Wong (:ewong)]

Attachment: Pop out CC and CXX from environment.

Comment 3

[Gregory Szorc [:gps]]

Comment on attachment 710554 [details] [diff] [review]
Pop out CC and CXX from environment.

Review of attachment 710554 [details] [diff] [review]:
-----------------------------------------------------------------

You found me just as I was going to bed!

Comment 4

[Edmund Wong (:ewong)]

Pushed to try:
https://tbpl.mozilla.org/?tree=Try&rev=4bf722f2ea84

Comment 5

[Edmund Wong (:ewong)]

Pushed to mozilla-inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/de9b729d67dc

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/de9b729d67dc