Closed
Bug 838565
Opened 11 years ago
Closed 11 years ago
cc taf and find
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla21
People
(Reporter: tbsaunde, Assigned: tbsaunde)
Details
Attachments
(1 file)
10.78 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #710653 -
Flags: review?(bugs)
Comment 2•11 years ago
|
||
Comment on attachment 710653 [details] [diff] [review] cc taf and nsFind >-NS_IMPL_ISUPPORTS1(nsFindContentIterator, nsIContentIterator) >+NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(nsFindContentIterator) >+ NS_INTERFACE_MAP_ENTRY(nsIContentIterator) >+ NS_INTERFACE_MAP_ENTRY(nsISupports) >+ NS_INTERFACE_MAP_END 2 extra spaces before NS_INTERFACE_MAP_END >+ NS_IMPL_CYCLE_COLLECTING_ADDREF(nsFindContentIterator) >+ NS_IMPL_CYCLE_COLLECTING_RELEASE(nsFindContentIterator) Two extra spaces before these macros >+ >+NS_IMPL_CYCLE_COLLECTION_6(nsFindContentIterator, mOuterIterator, mInnerIterator, mStartOuterContent, mEndOuterContent, mEndNode, mStartNode) Could you split this to two lines. Atm it is a bit too long >-NS_IMPL_ISUPPORTS1(nsFind, nsIFind) >+NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(nsFind) >+ NS_INTERFACE_MAP_ENTRY(nsIFind) >+ NS_INTERFACE_MAP_ENTRY(nsISupports) >+ NS_INTERFACE_MAP_END 2 extra spaces before NS_INTERFACE_MAP_END >+ >+ NS_IMPL_CYCLE_COLLECTING_ADDREF(nsFind) >+ NS_IMPL_CYCLE_COLLECTING_RELEASE(nsFind) 2 extra spaces before these macros >+++ b/memory/build/replace_malloc.c This change is for some other bug.
Attachment #710653 -
Flags: review?(bugs) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/526130001ba8
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/526130001ba8
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•