Status

()

RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: tbsaunde, Assigned: tbsaunde)

Tracking

unspecified
mozilla21
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

6 years ago
Created attachment 710653 [details] [diff] [review]
cc taf and nsFind
Attachment #710653 - Flags: review?(bugs)

Comment 2

6 years ago
Comment on attachment 710653 [details] [diff] [review]
cc taf and nsFind


>-NS_IMPL_ISUPPORTS1(nsFindContentIterator, nsIContentIterator)
>+NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(nsFindContentIterator)
>+  NS_INTERFACE_MAP_ENTRY(nsIContentIterator)
>+  NS_INTERFACE_MAP_ENTRY(nsISupports)
>+  NS_INTERFACE_MAP_END
2 extra spaces before NS_INTERFACE_MAP_END

>+  NS_IMPL_CYCLE_COLLECTING_ADDREF(nsFindContentIterator)
>+  NS_IMPL_CYCLE_COLLECTING_RELEASE(nsFindContentIterator)
Two extra spaces before these macros


>+
>+NS_IMPL_CYCLE_COLLECTION_6(nsFindContentIterator, mOuterIterator, mInnerIterator, mStartOuterContent, mEndOuterContent, mEndNode, mStartNode)
Could you split this to two lines. Atm it is a bit too long


>-NS_IMPL_ISUPPORTS1(nsFind, nsIFind)
>+NS_INTERFACE_MAP_BEGIN_CYCLE_COLLECTION(nsFind)
>+  NS_INTERFACE_MAP_ENTRY(nsIFind)
>+  NS_INTERFACE_MAP_ENTRY(nsISupports)
>+  NS_INTERFACE_MAP_END
2 extra spaces before NS_INTERFACE_MAP_END


>+
>+  NS_IMPL_CYCLE_COLLECTING_ADDREF(nsFind)
>+  NS_IMPL_CYCLE_COLLECTING_RELEASE(nsFind)
2 extra spaces before these macros

>+++ b/memory/build/replace_malloc.c
This change is for some other bug.
Attachment #710653 - Flags: review?(bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/526130001ba8
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
You need to log in before you can comment on or make changes to this bug.