838579 - mozdevice - devicemanager.py bad indentation in findOpenPort

Status: RESOLVED FIXED

(Testing :: Mozbase, defect)

Description

[Bob Clary [:bc] (inactive)]

Attachment: patch

I ran into this running multiple instances of Autophone's server on a single machine where port conflicts would not result in incrementing the port seed.

In findOpenPort the raise should be nested under the if seed condition. The way it reads now, findOpenPort raising an exception the first time it hits a problem such as an address in use.

                 except:
                     if seed > maxportnum:
                         print "Automation Error: Could not find open port after checking 5000 ports"
-                    raise
+                        raise
                 seed += 1

Comment 1

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 710657 [details] [diff] [review]
patch

Review of attachment 710657 [details] [diff] [review]:
-----------------------------------------------------------------

good find!

Comment 2

[Jeff Hammel]

pushed: https://github.com/mozilla/mozbase/commit/e7e5e8a602c386d99407eb2c0c1dd51ccab23fba 

Thanks for the patch, Bob!