Closed
Bug 838599
Opened 11 years ago
Closed 11 years ago
Downloads summary description font is too large
Categories
(Firefox :: Downloads Panel, defect)
Tracking
()
VERIFIED
FIXED
Firefox 21
Tracking | Status | |
---|---|---|
firefox20 | --- | verified |
People
(Reporter: mconley, Assigned: mconley)
References
Details
(Keywords: polish)
Attachments
(6 files)
21.49 KB,
image/png
|
Details | |
4.53 KB,
patch
|
mak
:
review+
Gavin
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
47.12 KB,
image/png
|
Details | |
38.55 KB,
image/png
|
Details | |
47.51 KB,
image/png
|
Details | |
29.32 KB,
image/png
|
Details |
The "+ X other downloads" string has a slightly inflated font. This is fallout from bug 828302 - we failed to take into account the fact that the summary also has elements that use the .downloadContainer and .downloadTarget classes.
Assignee | ||
Comment 1•11 years ago
|
||
This patch removes the .downloadSummary and .downloadTarget classes from the summary, and we special-case the CSS rules for #downloadsSummaryDetails and #downloadsSummaryDescription instead. Tested on Ubuntu, and it looks right. Screenshots coming.
Assignee | ||
Comment 2•11 years ago
|
||
Assignee | ||
Comment 3•11 years ago
|
||
Assignee | ||
Comment 4•11 years ago
|
||
Assignee | ||
Comment 5•11 years ago
|
||
Assignee | ||
Comment 6•11 years ago
|
||
Comment on attachment 710732 [details] [diff] [review] Patch v1 How does this look?
Attachment #710732 -
Flags: review?(mak77)
Comment 7•11 years ago
|
||
Comment on attachment 710732 [details] [diff] [review] Patch v1 Review of attachment 710732 [details] [diff] [review]: ----------------------------------------------------------------- ook, this makes the styling a bit more complex, but I can't see an alternative atm. Thanks!
Attachment #710732 -
Flags: review?(mak77) → review+
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/e22bf3f9e372
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e22bf3f9e372
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 21
Comment 10•11 years ago
|
||
Comment on attachment 710732 [details] [diff] [review] Patch v1 [Approval Request Comment] Bug caused by (feature/regressing bug #): downloads panel feature User impact if declined: wrongly sized text in the panel Testing completed (on m-c, etc.): m-c Risk to taking this patch (and alternatives if risky): minor, polish limited to the feature String or UUID changes made by this patch: none
Attachment #710732 -
Flags: approval-mozilla-aurora?
Updated•11 years ago
|
Attachment #710732 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 11•11 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/d0730b726ee0
status-firefox20:
--- → fixed
Comment 12•11 years ago
|
||
Verified as fixed on the latest Nightly and Aurora - the downloads summary description font is properly displayed. Verified on Windows 7, Windows XP, Ubuntu 12.10 and Mac OS X 10.7: Mozilla/5.0 (Windows NT 6.1; rv:21.0) Gecko/20130212 Firefox/21.0 (20130212031120) Mozilla/5.0 (Windows NT 6.1; rv:20.0) Gecko/20130212 Firefox/20.0 (20130212042017) Mozilla/5.0 (Windows NT 5.1; rv:21.0) Gecko/20130212 Firefox/21.0 (20130212031120) Mozilla/5.0 (Windows NT 5.1; rv:20.0) Gecko/20130212 Firefox/20.0 (20130212042017) Mozilla/5.0 (X11; Linux i686; rv:21.0) Gecko/20130211 Firefox/21.0 (20130211031055) Mozilla/5.0 (X11; Linux i686; rv:20.0) Gecko/20130212 Firefox/20.0 (20130212042017) Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:21.0) Gecko/20130213 Firefox/21.0 (20130213031137) Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:20.0) Gecko/20130213 Firefox/20.0 (20130213042019)
Updated•11 years ago
|
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•