Add disabled-by-default logcat logging to ProcessPriorityManager and improve the logging a bit

RESOLVED FIXED in Firefox 21

Status

()

defect
RESOLVED FIXED
7 years ago
6 years ago

People

(Reporter: justin.lebar+bug, Unassigned)

Tracking

Trunk
mozilla21
Points:
---

Firefox Tracking Flags

(firefox19 wontfix, firefox20 wontfix, firefox21 fixed, b2g18 fixed, b2g18-v1.0.0 wontfix, b2g18-v1.0.1 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

It would be helpful to me if we had a simple way to enable ProcessPriorityManager logcat logging.  Rather than permanently keep this patch in my queue, I'd prefer to check it in.
Posted patch Patch, v1 (obsolete) — Splinter Review
Attachment #710718 - Flags: review?(jones.chris.g)
Fixed a comment
Attachment #710760 - Flags: review?(jones.chris.g)
Attachment #710718 - Attachment is obsolete: true
Attachment #710718 - Flags: review?(jones.chris.g)
Attachment #710761 - Flags: review?(jones.chris.g)
Summary: Add disabled-by-default logcat logging to ProcessPriorityManager → Add disabled-by-default logcat logging to ProcessPriorityManager and improve the logging a bit
Comment on attachment 710760 [details] [diff] [review]
Patch, v2: Add logcat logging to ProcessPriorityManager.

(Obligatory grumble about sad state of logging, but not your fault.)
Attachment #710760 - Flags: review?(jones.chris.g) → review+
Attachment #710761 - Flags: review?(jones.chris.g) → review+
Comment on attachment 710760 [details] [diff] [review]
Patch, v2: Add logcat logging to ProcessPriorityManager.

[Approval Request Comment]
Zero-risk change; all of this code is off by default.  You have to modify the code (remove an |#if 0|) in order to enable it.

This code is helpful for my continued debugging of bug 836199, a tef blocker.
Attachment #710760 - Flags: approval-mozilla-b2g18?
Attachment #710761 - Flags: approval-mozilla-b2g18?
https://hg.mozilla.org/mozilla-central/rev/41ce5bbd6859
https://hg.mozilla.org/mozilla-central/rev/35cc0b94300b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla21
Attachment #710760 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Attachment #710761 - Flags: approval-mozilla-b2g18? → approval-mozilla-b2g18+
Batch edit: Bugs fixed on b2g18 after 1/25 merge to v1.0 branch are fixed on v1.0.1 branch.
You need to log in before you can comment on or make changes to this bug.