838639 - Handle errors when failing to take a picture

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Comment 1

[Dale Harvey (:daleharvey)]

Attachment: Pointer to Github PR

I reused the error from failing to save the photo, I dont think we should be distuingishing between the 2 errors since they have the same user impact

Comment 2

[David Flanagan [:djf]]

Comment on attachment 710753 [details]
Pointer to Github PR

The code looks good to me.

I agree that there is no point distinguishing to the user between these two types of errors.

Ideally, the error message should change to be more generic and not used the word "saved".  But it is probably not worth doing late-1l0n for that.  Last I heard, there is not a gaia-l10n branch for 1.1 or whatever this is targeted at, is there?

Comment 3

[Dale Harvey (:daleharvey)]

Merged in https://github.com/mozilla-b2g/gaia/commit/04a78898293bfb943f103874040b587a1026ff19

Yeh I havent seen anything about string changes, so I have been leaning on the side of avoiding them. 

Cheers

Comment 4

[Alex Keybl [:akeybl]]

(In reply to Dale Harvey (:daleharvey) from comment #3)
> Merged in
> https://github.com/mozilla-b2g/gaia/commit/
> 04a78898293bfb943f103874040b587a1026ff19
> 
> Yeh I havent seen anything about string changes, so I have been leaning on
> the side of avoiding them. 
> 
> Cheers

Dale - are you comfortable with taking this patch along with bug 834164 for v1.0.1? If so, please nominate for uplift.

Comment 5

[Dale Harvey (:daleharvey)]

Sorry missed this email, I am comfortable with this patch to get uplifted, however the option to nominate it for approval does not appear for me

Comment 6

[David Flanagan [:djf]]

uplifted to v1-train: https://github.com/mozilla-b2g/gaia/commit/4b02489859ab5989d517649a287598af1b186223