Closed Bug 838679 Opened 11 years ago Closed 11 years ago

Make nsMenuFrame::RemoveFrame not use DestroyFrameIfPresent

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla22

People

(Reporter: MatsPalmgren_bugz, Assigned: MatsPalmgren_bugz)

References

Details

Attachments

(1 file)

fix
1.06 KB, patch
bzbarsky
: review+
Details | Diff | Splinter Review 
The popupList only has one frame on it so we can just the first child.
DestroyPopupList() asserts it's empty.

(the goal is to remove DestroyFrameIfPresent which is O(n))
Attached patch fix — — Splinter Review 

        Attachment #710778 -
        Flags: review?(bzbarsky)

    
  
Assignee: nobody → matspal

    
  
Blocks: 838706

    
    

    
  
Comment on attachment 710778 [details] [diff] [review]
fix

r=me

        Attachment #710778 -
        Flags: review?(bzbarsky) → review+

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/aee03685cd2b
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla22

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: