Closed
Bug 838710
Opened 12 years ago
Closed 12 years ago
Going off the origin of a web app within the app content - no indication of the app origin in UI
Categories
(Firefox OS Graveyard :: Gaia::System, defect)
Tracking
(blocking-b2g:tef+, b2g18 fixed, b2g18-v1.0.0 fixed, b2g18-v1.0.1 fixed)
VERIFIED
FIXED
blocking-b2g | tef+ |
People
(Reporter: amac, Assigned: alive)
References
Details
(Keywords: regression)
Attachments
(1 file)
+++ This bug was initially created as a clone of Bug #822049 +++
The solution that was implemented in bug 822049 for showing that we're off-origin on apps (on the task browser) seem to have regressed again.
Doing a simple document.location.href="http://some.other.place" and going into the task manager shows only the App Name without any indication of having gone off-origin whatsoever.
Updated•12 years ago
|
Priority: P2 → --
Comment 1•12 years ago
|
||
Let's try to find the regression here and back it out.
Assignee | ||
Comment 2•12 years ago
|
||
Steal.
Assignee | ||
Updated•12 years ago
|
Assignee: jduell.mcbugs → alive
Assignee | ||
Comment 3•12 years ago
|
||
Patch: use the correct object to do url compare.
Attachment #711902 -
Flags: review?(21)
Assignee | ||
Comment 4•12 years ago
|
||
(In reply to Alive Kuo [:alive](on Chinese New Year: 2/7~2/17) from comment #3)
> Created attachment 711902 [details]
> https://github.com/mozilla-b2g/gaia/pull/8029
>
> Patch: use the correct object to do url compare.
I haven't wroten an unit test because
1). I don't think a test here could help -- we should change the way we use to communicate between modules in the future, or else regression like this would happen again. But before saying that, yes, this is a regression due to appWindow work :/
2). Window Manager stuffs now are nearly not unit-testable IMO. Another pain of module pattern. There are too many private functions with implicit data expose like this one. Mock Window Manager could be very scary in the long run.
I could write a test if the reviewer insists.
Attachment #711902 -
Flags: review?(21) → review+
Comment 5•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
status-b2g18:
--- → affected
status-b2g18-v1.0.0:
--- → affected
status-b2g18-v1.0.1:
--- → affected
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
v1-train: ecca2ee860825547d5e1109436b50b74dfe9261e
v1.0.0: 282b42d271c4259d854a9ea7bd3918ba8e2a6916
You need to log in
before you can comment on or make changes to this bug.
Description
•