838713 - Skip slow-startup-check if Services.startup.interrupted is true

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[Jared Wein [:jaws] (please needinfo? me)]

The measurements are less reliable in these conditions and aren't likely representative of a true "slow" startup.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

I'm not sure what impact this can have, :vladan may know more, but we shouldn't alert users about a slow startup if the slow startup was the result of an update.

Comment 2

[Vladan Djeric (:vladan)]

This flag is set if the extension update dialog pops up after launching an updated version of Firefox (i.e. "Checking your add-ons for compatibility with this version of Firefox"). It delays some of the startup milestones

Comment 3

[Dão Gottwald [:dao]]

Attachment: patch

Comment 4

[Dão Gottwald [:dao]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b399e0488c09

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b399e0488c09

Comment 6

[Dão Gottwald [:dao]]

Comment on attachment 715507 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 836010
User impact if declined: slow startup notification showing up based on bogus startup measurements
Testing completed (on m-c, etc.): on m-c
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 7

[Dão Gottwald [:dao]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6fce4468d80f

Comment 8

[u279076]

Is there anything QA can do to verify this is fixed?