838756 - build warning for out-of-order UnixSocketImpl init list, in UnixSocket.cpp

Status: RESOLVED FIXED

(Core :: DOM: Device Interfaces, defect)

Description

[Daniel Holbert [:dholbert]]

New build warning:
{
UnixSocket.cpp
/mozilla-central/mozilla/ipc/unixsocket/UnixSocket.cpp: In constructor 'mozilla::ipc::UnixSocketImpl::UnixSocketImpl(mozilla::ipc::UnixSocketConsumer*, mozilla::ipc::UnixSocketConnector*, const nsACString_internal&)':
/mozilla-central/mozilla/ipc/unixsocket/UnixSocket.cpp:238:19: warning: 'mozilla::ipc::UnixSocketImpl::mTask' will be initialized after [-Wreorder]
/mozilla-central/mozilla/ipc/unixsocket/UnixSocket.cpp:222:15: warning:   'mozilla::ScopedClose mozilla::ipc::UnixSocketImpl::mFd' [-Wreorder]
/mozilla-central/mozilla/ipc/unixsocket/UnixSocket.cpp:46:3: warning:   when initialized here [-Wreorder]
}

introduced by bug 826931 inserting mTask(nullptr) at the wrong point in the init list.

Comment 1

[Daniel Holbert [:dholbert]]

Er, copypaste fail -- I meant to say "bug 836107" at the end of comment 0.
 (this cset: https://hg.mozilla.org/releases/mozilla-b2g18/rev/9fa5629ee60c )

Comment 2

[Daniel Holbert [:dholbert]]

Attachment: fix

This fixes the warning.

As shown by this MXR page, mTask is declared right after mCurrentTaskIsCanceled:
https://mxr.mozilla.org/mozilla-central/source/ipc/unixsocket/UnixSocket.cpp?mark=232-238#229
...so it should be right after mCurrentTaskIsCanceled in the init list, too. (And this patch makes it so.)

Comment 3

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/d9708e34085a

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/d9708e34085a